Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the LC reboot-cause check since it's broken on Arista #16755

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Skip the LC reboot-cause check since it's broken on Arista #16755

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66f6304
Skip the LC reboot-cause check since it's broken on Arista
arista-nwolfe Feb 1, 2025
60080db
Fixing 'line too long' error
arista-nwolfe Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 33 additions & 20 deletions tests/bgp/test_startup_tsa_tsb_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,11 +633,14 @@ def config_reload_linecard_if_unhealthy(lc):
executor.submit(config_reload_linecard_if_unhealthy, linecard)

for linecard in duthosts.frontend_nodes:
# Make sure the dut's reboot cause is as expected
logger.info("Check reboot cause of the dut {}".format(linecard))
reboot_cause = get_reboot_cause(linecard)
pytest_assert(reboot_cause == SUP_REBOOT_CAUSE,
"Reboot cause {} did not match the trigger {}".format(reboot_cause, SUP_REBOOT_CAUSE))
# Arista platforms currently return an unexpected reboot-cause in certain test cases
# https://github.com/aristanetworks/sonic/issues/118
if 'arista_7800' not in linecard.facts['platform'].lower():
# Make sure the dut's reboot cause is as expected
logger.info("Check reboot cause of the dut {}".format(linecard))
reboot_cause = get_reboot_cause(linecard)
pytest_assert(reboot_cause == SUP_REBOOT_CAUSE,
"Reboot cause {} did not match the trigger {}".format(reboot_cause, SUP_REBOOT_CAUSE))

# Make sure the Supervisor's reboot cause is as expected
logger.info("Check reboot cause of the supervisor")
Expand Down Expand Up @@ -797,11 +800,15 @@ def config_reload_linecard_if_unhealthy(lc):
executor.submit(config_reload_linecard_if_unhealthy, linecard)

for linecard in duthosts.frontend_nodes:
# Make sure the dut's reboot cause is as expected
logger.info("Check reboot cause of the dut {}".format(linecard))
reboot_cause = get_reboot_cause(linecard)
pytest_assert(reboot_cause == SUP_HEARTBEAT_LOSS_CAUSE,
"Reboot cause {} did not match the trigger {}".format(reboot_cause, SUP_HEARTBEAT_LOSS_CAUSE))
# Arista platforms currently return an unexpected reboot-cause in certain test cases
# https://github.com/aristanetworks/sonic/issues/118
if 'arista_7800' not in linecard.facts['platform'].lower():
# Make sure the dut's reboot cause is as expected
logger.info("Check reboot cause of the dut {}".format(linecard))
reboot_cause = get_reboot_cause(linecard)
pytest_assert(reboot_cause == SUP_HEARTBEAT_LOSS_CAUSE,
"Reboot cause {} did not match the trigger {}".format(
reboot_cause, SUP_HEARTBEAT_LOSS_CAUSE))

# Make sure the Supervisor's reboot cause is as expected
logger.info("Check reboot cause of the supervisor")
Expand Down Expand Up @@ -1360,11 +1367,14 @@ def config_reload_linecard_if_unhealthy(lc):
executor.submit(config_reload_linecard_if_unhealthy, linecard)

for linecard in duthosts.frontend_nodes:
# Make sure the dut's reboot cause is as expected
logger.info("Check reboot cause of the dut {}".format(linecard))
reboot_cause = get_reboot_cause(linecard)
pytest_assert(reboot_cause == SUP_REBOOT_CAUSE,
"Reboot cause {} did not match the trigger {}".format(reboot_cause, SUP_REBOOT_CAUSE))
# Arista platforms currently return an unexpected reboot-cause in certain test cases
# https://github.com/aristanetworks/sonic/issues/118
if 'arista_7800' not in linecard.facts['platform'].lower():
# Make sure the dut's reboot cause is as expected
logger.info("Check reboot cause of the dut {}".format(linecard))
reboot_cause = get_reboot_cause(linecard)
pytest_assert(reboot_cause == SUP_REBOOT_CAUSE,
"Reboot cause {} did not match the trigger {}".format(reboot_cause, SUP_REBOOT_CAUSE))

# Make sure the Supervisor's reboot cause is as expected
logger.info("Check reboot cause of the supervisor")
Expand Down Expand Up @@ -1641,11 +1651,14 @@ def config_reload_linecard_if_unhealthy(lc):
executor.submit(config_reload_linecard_if_unhealthy, linecard)

for linecard in duthosts.frontend_nodes:
# Make sure the dut's reboot cause is as expected
logger.info("Check reboot cause of the dut {}".format(linecard))
reboot_cause = get_reboot_cause(linecard)
pytest_assert(reboot_cause == SUP_REBOOT_CAUSE,
"Reboot cause {} did not match the trigger {}".format(reboot_cause, SUP_REBOOT_CAUSE))
# Arista platforms currently return an unexpected reboot-cause in certain test cases
# https://github.com/aristanetworks/sonic/issues/118
if 'arista_7800' not in linecard.facts['platform'].lower():
# Make sure the dut's reboot cause is as expected
logger.info("Check reboot cause of the dut {}".format(linecard))
reboot_cause = get_reboot_cause(linecard)
pytest_assert(reboot_cause == SUP_REBOOT_CAUSE,
"Reboot cause {} did not match the trigger {}".format(reboot_cause, SUP_REBOOT_CAUSE))

# Make sure the Supervisor's reboot cause is as expected
logger.info("Check reboot cause of the supervisor")
Expand Down
Loading