Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P4_symbolic] Enable secure connection for p4rt_route_test. Migrate program to new SAI API for setting VRFs. update comments to use inclusive naming from github and p4.org Add route_metadata field and initializing logic to reflect the changes in SAI-P4 code. Remove program-specific structs mixed in with the generic API. #626

Merged
merged 13 commits into from
Oct 19, 2024

Conversation

VSuryaprasad-HCL
Copy link
Contributor

Keyword Check:
/sonic-buildimage/src/sonic-p4rt/sonic-pins$ ~/tools/keyword_checks.sh .
Keyword check Passed.

Build Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel build $BAZEL_BUILD_OPTS ...
DEBUG: Rule 'com_github_nelhage_rules_boost' indicated that a canonical reproducible form can be obtained by modifying arguments shallow_since = "1619053724 -0700"
DEBUG: Repository com_github_nelhage_rules_boost instantiated at:
/sonic/src/sonic-p4rt/sonic-pins/WORKSPACE.bazel:75:9: in
/var/vsurya/.cache/bazel/_bazel_vsurya/5fd88bad78ef03829a4685c83637a020/external/com_github_p4lang_p4c/bazel/p4c_deps.bzl:25:23: in p4c_deps
Repository rule git_repository defined at:
/var/vsurya/.cache/bazel/_bazel_vsurya/5fd88bad78ef03829a4685c83637a020/external/bazel_tools/tools/build_defs/repo/git.bzl:199:33: in
INFO: Analyzed 520 targets (0 packages loaded, 0 targets configured).
INFO: Found 520 targets...
INFO: From Compiling p4_symbolic/tests/sai_p4_component_test.cc:
In file included from p4_symbolic/tests/sai_p4_component_test.cc:9:
p4_symbolic/tests/sai_p4_component_test.cc: In member function 'virtual void p4_symbolic::{anonymous}::P4SymbolicComponentTest_CanGenerateTestPacketsForSimpleSaiP4Entries_Test::TestBody()':
p4_symbolic/tests/sai_p4_component_test.cc:105:32: warning: 'absl::lts_20230802::StatusOrp4::v1::TableEntry pdpi::PartialPdTableEntryToPiTableEntry(const pdpi::IrP4Info&, const google::protobuf::Message&, const pdpi::TranslationOptions&)' is deprecated: Use PdTableEntryToPiEntity instead [-Wdeprecated-declarations]
105 | pdpi::PartialPdTableEntryToPiTableEntry(ir_p4info, pd_entry));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./gutil/status_matchers.h:64:43: note: in definition of macro 'ASSERT_OK_AND_ASSIGN'
64 | auto __ASSIGN_OR_RETURN_VAL(LINE) = expression;
| ^~~~~~~~~~
In file included from p4_symbolic/tests/sai_p4_component_test.cc:14:
./p4_pdpi/pd.h:141:36: note: declared here
141 | absl::StatusOrp4::v1::TableEntry PartialPdTableEntryToPiTableEntry(
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from p4_symbolic/tests/sai_p4_component_test.cc:9:
p4_symbolic/tests/sai_p4_component_test.cc:105:85: warning: 'absl::lts_20230802::StatusOrp4::v1::TableEntry pdpi::PartialPdTableEntryToPiTableEntry(const pdpi::IrP4Info&, const google::protobuf::Message&, const pdpi::TranslationOptions&)' is deprecated: Use PdTableEntryToPiEntity instead [-Wdeprecated-declarations]
105 | pdpi::PartialPdTableEntryToPiTableEntry(ir_p4info, pd_entry));
| ^
./gutil/status_matchers.h:64:43: note: in definition of macro 'ASSERT_OK_AND_ASSIGN'
64 | auto __ASSIGN_OR_RETURN_VAL(LINE) = expression;
| ^~~~~~~~~~
In file included from p4_symbolic/tests/sai_p4_component_test.cc:14:
./p4_pdpi/pd.h:141:36: note: declared here
141 | absl::StatusOrp4::v1::TableEntry PartialPdTableEntryToPiTableEntry(
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
INFO: Elapsed time: 12.794s, Critical Path: 11.16s
INFO: 3 processes: 1 internal, 2 linux-sandbox.
INFO: Build completed successfully, 3 total actions

Test Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS --cache_test_results=no ...
DEBUG: Rule 'com_github_nelhage_rules_boost' indicated that a canonical reproducible form can be obtained by modifying arguments shallow_since = "1619053724 -0700"
DEBUG: Repository com_github_nelhage_rules_boost instantiated at:
/sonic/src/sonic-p4rt/sonic-pins/WORKSPACE.bazel:75:9: in
/var/vsurya/.cache/bazel/_bazel_vsurya/5fd88bad78ef03829a4685c83637a020/external/com_github_p4lang_p4c/bazel/p4c_deps.bzl:25:23: in p4c_deps
Repository rule git_repository defined at:
/var/vsurya/.cache/bazel/_bazel_vsurya/5fd88bad78ef03829a4685c83637a020/external/bazel_tools/tools/build_defs/repo/git.bzl:199:33: in
INFO: Analyzed 520 targets (0 packages loaded, 0 targets configured).
INFO: Found 347 targets and 173 test targets...
INFO: Elapsed time: 125.973s, Critical Path: 49.92s
INFO: 182 processes: 215 linux-sandbox, 18 local.
INFO: Build completed successfully, 182 total actions
//gutil:collections_test PASSED in 0.5s
//gutil:io_test PASSED in 0.5s
//gutil:proto_matchers_test PASSED in 0.7s
//gutil:proto_ordering_test PASSED in 0.6s
//gutil:proto_test PASSED in 0.6s
//p4rt_app/tests:forwarding_pipeline_config_test PASSED in 7.8s
//p4rt_app/tests:grpc_behavior_test PASSED in 5.6s
//p4rt_app/tests:p4_constraints_test PASSED in 0.3s
//p4rt_app/tests:p4_constraints_test_runner PASSED in 0.5s
//p4rt_app/tests:p4_programs_test PASSED in 2.6s
//p4rt_app/tests:packet_replication_table_test PASSED in 2.9s
//p4rt_app/tests:packetio_test PASSED in 4.6s
//p4rt_app/tests:port_name_and_id_test PASSED in 3.9s
//p4rt_app/tests:resource_limits_test PASSED in 3.0s
//p4rt_app/tests:response_path_test PASSED in 5.5s
//p4rt_app/tests:role_test PASSED in 1.6s
//p4rt_app/tests:state_verification_test PASSED in 2.8s
//p4rt_app/tests:vrf_table_test PASSED in 2.7s
//p4rt_app/tests/lib:app_db_entry_builder_test PASSED in 0.0s
//p4rt_app/utils:event_data_tracker_test PASSED in 0.0s
//p4rt_app/utils:table_utility_test PASSED in 0.7s
//sai_p4/instantiations/google:clos_stage_test PASSED in 0.5s
//sai_p4/instantiations/google:fabric_border_router_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google:middleblock_p4info_up_to_date_test PASSED in 0.1s
//sai_p4/instantiations/google:sai_nonstandard_platforms_build_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_nonstandard_platforms_cc_test PASSED in 0.6s
//sai_p4/instantiations/google:sai_p4info_fetcher_test PASSED in 0.7s
//sai_p4/instantiations/google:sai_p4info_test PASSED in 1.1s
//sai_p4/instantiations/google:sai_pd_proto_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_pd_util_test PASSED in 0.6s
//sai_p4/instantiations/google:tor_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google:union_p4info_up_to_date_test PASSED in 0.1s
//sai_p4/instantiations/google:wbb_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google/test_tools:table_entry_generator_helper_test PASSED in 3.9s
//sai_p4/instantiations/google/test_tools:test_entries_test PASSED in 0.9s
//sai_p4/tools:p4info_tools_test PASSED in 0.7s
//sai_p4/tools:packetio_tools_test PASSED in 0.8s
//thinkit:bazel_test_environment_test PASSED in 0.6s
//thinkit:generic_testbed_test PASSED in 1.1s
//thinkit:mock_control_device_test PASSED in 0.6s
//thinkit:mock_generic_testbed_test PASSED in 0.8s
//thinkit:mock_mirror_testbed_test PASSED in 0.7s
//thinkit:mock_ssh_client_test PASSED in 0.1s
//thinkit:mock_switch_test PASSED in 0.8s
//thinkit:mock_test_environment_test PASSED in 0.1s
//thinkit:switch_test PASSED in 1.0s
//sai_p4/instantiations/google/test_tools:table_entry_generator_test PASSED in 49.8s
Stats over 5 runs: max = 49.8s, min = 6.9s, avg = 39.1s, dev = 16.3s
//sai_p4/instantiations/google/tests:p4_constraints_integration_test PASSED in 1.1s
Stats over 5 runs: max = 1.1s, min = 0.7s, avg = 0.9s, dev = 0.1s

Executed 173 out of 173 tests: 173 tests pass.
INFO: Build completed successfully, 182 total actions

smolkaj and others added 11 commits October 8, 2024 10:56
…os and making things reusable. Fix a few subtle bugs related to dropping packets and ports. Move Z3 utility functions into z3_util. Make evaluation functions only return a set of matches instead of an entire trace.
…e (spurious) visibility declarations; make all targets public.
… field that tracks cloning.

PiperOrigin-RevId: 373904870
@VSuryaprasad-HCL
Copy link
Contributor Author

Co-authored-by: Steffen Smolka [email protected]
Co-authored-by: kheradmandG [email protected]
Co-authored-by: Robert Halstead [email protected]
Co-authored-by: Srikishen Pondicherry Shanmugam [email protected]

…SAI API for setting VRFs. update comments to use inclusive naming from github and p4.org Add route_metadata field and initializing logic to reflect the changes in SAI-P4 code. Remove program-specific structs mixed in with the generic API.
Copy link
Contributor

@bibhuprasad-hcl bibhuprasad-hcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kishanps, Could you please review.
Thanks.

@kishanps kishanps merged commit 33cca1a into sonic-net:main Oct 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants