[CMIS]The "get_error_description" function should return 'OK' instead of None when there are no errors. #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s no error Signed-off-by: Kebo Liu <[email protected]>
Junchao-Mellanox
approved these changes
Nov 29, 2024
mihirpat1
approved these changes
Dec 2, 2024
|
@prgeor would you please help to merge? |
liat-grozovik
approved these changes
Dec 9, 2024
|
@keboliu on which branches this change should go? |
bingwang-ms
added
Approved for 202405 Branch
and removed
Approved for 202405 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-common
that referenced
this pull request
Dec 18, 2024
…s no error (sonic-net#518) - Description The "get_error_description" function should return 'OK' instead of 'None' when there are no errors. - Motivation and Context When there are no errors on the cable, get_error_description currently returns 'None'. In this case, we should return 'OK' so that the CLI (show interface transceiver error-description) provides a proper output. - How Has This Been Tested? Call this API directly on different cables with different error statuses. Signed-off-by: Kebo Liu <[email protected]>
|
Cherry-pick PR to 202405: #524 |
mssonicbld
pushed a commit
that referenced
this pull request
Dec 18, 2024
…s no error (#518) - Description The "get_error_description" function should return 'OK' instead of 'None' when there are no errors. - Motivation and Context When there are no errors on the cable, get_error_description currently returns 'None'. In this case, we should return 'OK' so that the CLI (show interface transceiver error-description) provides a proper output. - How Has This Been Tested? Call this API directly on different cables with different error statuses. Signed-off-by: Kebo Liu <[email protected]>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
|
Cherry-pick PR to 202411: #528 |
mssonicbld
added
Included in 202411 Branch
and removed
Created PR to 202411 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The "get_error_description" function should return 'OK' instead of 'None' when there are no errors.
Motivation and Context
When there are no errors on the cable, get_error_description currently returns 'None'. In this case, we should return 'OK' so that the CLI (show interface transceiver error-description) provides a proper output.
How Has This Been Tested?
Call this API directly on different cables with different error statuses.
Additional Information (Optional)