-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xcvrd] silence port update event warnings #567
Open
bradh352
wants to merge
2
commits into
sonic-net:master
Choose a base branch
from
bradh352:xcvrd-silence-warnings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihirpat1
approved these changes
Dec 13, 2024
bradh352
added a commit
to bradh352/sonic-platform-daemons
that referenced
this pull request
Dec 24, 2024
Warnings should only be used to alert an administrator that something could cause issues. Typically warnings will be evaluated by an administrator as tagged by their SIEM, so it makes sense to reduce the workload by not incorrectly tagging these log messages. Reduced the log level to NOTICE which will still appear at the default log levels in case anyone is parsing these events in their SIEM. Signed-off-by: Brad House (@bradh352)
bradh352
added a commit
to bradh352/sonic-platform-daemons
that referenced
this pull request
Dec 24, 2024
Warnings should only be used to alert an administrator that something could cause issues. Typically warnings will be evaluated by an administrator as tagged by their SIEM, so it makes sense to reduce the workload by not incorrectly tagging these log messages. Reduced the log level to NOTICE which will still appear at the default log levels in case anyone is parsing these events in their SIEM. Signed-off-by: Brad House (@bradh352)
bradh352
added a commit
to bradh352/sonic-platform-daemons
that referenced
this pull request
Dec 24, 2024
Warnings should only be used to alert an administrator that something could cause issues. Typically warnings will be evaluated by an administrator as tagged by their SIEM, so it makes sense to reduce the workload by not incorrectly tagging these log messages. Reduced the log level to NOTICE which will still appear at the default log levels in case anyone is parsing these events in their SIEM. Signed-off-by: Brad House (@bradh352)
bradh352
added a commit
to bradh352/sonic-platform-daemons
that referenced
this pull request
Dec 24, 2024
Warnings should only be used to alert an administrator that something could cause issues. Typically warnings will be evaluated by an administrator as tagged by their SIEM, so it makes sense to reduce the workload by not incorrectly tagging these log messages. Reduced the log level to NOTICE which will still appear at the default log levels in case anyone is parsing these events in their SIEM. Signed-off-by: Brad House (@bradh352)
bradh352
added a commit
to bradh352/sonic-platform-daemons
that referenced
this pull request
Jan 2, 2025
Warnings should only be used to alert an administrator that something could cause issues. Typically warnings will be evaluated by an administrator as tagged by their SIEM, so it makes sense to reduce the workload by not incorrectly tagging these log messages. Reduced the log level to NOTICE which will still appear at the default log levels in case anyone is parsing these events in their SIEM. Signed-off-by: Brad House (@bradh352)
bradh352
added a commit
to bradh352/sonic-platform-daemons
that referenced
this pull request
Jan 2, 2025
Warnings should only be used to alert an administrator that something could cause issues. Typically warnings will be evaluated by an administrator as tagged by their SIEM, so it makes sense to reduce the workload by not incorrectly tagging these log messages. Reduced the log level to NOTICE which will still appear at the default log levels in case anyone is parsing these events in their SIEM. Signed-off-by: Brad House (@bradh352)
Warnings should only be used to alert an administrator that something could cause issues. Typically warnings will be evaluated by an administrator as tagged by their SIEM, so it makes sense to reduce the workload by not incorrectly tagging these log messages. Reduced the log level to NOTICE which will still appear at the default log levels in case anyone is parsing these events in their SIEM. Signed-off-by: Brad House (@bradh352)
bradh352
force-pushed
the
xcvrd-silence-warnings
branch
from
January 9, 2025 13:37
acbbef1
to
1c7c4ff
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I just rebased this to force a rebuild since semgrep hung back on Dec 1 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
venkatmahalingam
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All port events are currently logged at the WARNING level. Reduce to NOTICE.
Example:
Motivation and Context
Warnings should only be used to alert an administrator that something could cause issues. Typically warnings will be evaluated by an administrator as tagged by their SIEM, so it makes sense to reduce the workload by not incorrectly tagging these log messages.
Reduced the log level to NOTICE which will still appear at the default log levels in case anyone is parsing these events in their SIEM.
How Has This Been Tested?
Build as part of my private fork at https://github.com/bradh352/sonic-buildimage and loaded onto physical switches.
Additional Information (Optional)
Signed-off-by: Brad House (@bradh352)