Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NOTICE log for flat memory to skip CMIS FSM #586

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AnoopKamath
Copy link
Contributor

@AnoopKamath AnoopKamath commented Feb 4, 2025

Description

no suitable app for the port appl ERROR message seen for flat memory modules

https://migsonic.atlassian.net/browse/MIGSMSFT-868

Motivation and Context

Although the DAC and AOC modules link up after " no suitable app for the port appl" error but it is flagged in SONIC management runs. This should be advertised in Page 0 Byte 2 bit 7 but some modules don't and cause this failure message. Add a NOTICE message for this case.

How Has This Been Tested?

Verify with DAC and AOC cables where we see this message.

Additional Information (Optional)

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mihirpat1
Copy link
Contributor

@AnoopKamath Agreed - flat memory modules should not go through the CMIS initialization sequence itself. Wondering why such modules are not being handled in the below block which is executed before CMIS initialization sequence begins?

if api.is_flat_memory():
self.log_notice("{}: skipping CMIS state machine for flat memory xcvr".format(lport))
self.update_port_transceiver_status_table_sw_cmis_state(lport, CMIS_STATE_READY)
continue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants