-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[syncd] Add workaround for port error status notification #1430
base: master
Are you sure you want to change the base?
Conversation
I'm just creating this PR to see what i miss from build, i will later split this to 2 PR's as advancing SAI submodule and then commiting actual workaround |
syncd/VendorSai.cpp
Outdated
@@ -1300,6 +1354,52 @@ sai_status_t VendorSai::bulkRemove( | |||
object_statuses); | |||
} | |||
|
|||
sai_status_t VendorSai::bulkRemove( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kcudnik I see this change is not relevant as per the PR title. Can this be kept outside this PR and added in another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
read this comment: #1430 (comment), this is 1st pr: #1431
syncd/VendorSai.cpp
Outdated
@@ -998,6 +998,60 @@ sai_status_t VendorSai::bulkCreate( | |||
object_statuses); | |||
} | |||
|
|||
sai_status_t VendorSai::bulkCreate( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kcudnik this change be added as another PR as this is NOT relevant as per the PR title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
read this comment: #1430 (comment), this is 1st pr: #1431
@kcudnik could you please check the build failure. |
SAI was updated in separate PR: #1431 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Adding new field in port status notification is breaking change and can cause some issues when getting notification from older SAI library, this will add workaround to handle that case
@prgeor why there was force push to my branch from you? |
Adding new field in port status notification is breaking
change and can cause some issues when getting notification
from older SAI library, this will add workaround to handle
that case