Skip to content

Commit

Permalink
Merge pull request #112 from soopercool101/RelPopulationCheck
Browse files Browse the repository at this point in the history
Remove unnecessary population check when disposing RELNodes
  • Loading branch information
squidgy617 authored Sep 6, 2024
2 parents 7b5a90c + e01f8c1 commit f0d2be6
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions BrawlLib/SSBB/ResourceNodes/Modules/RELNode.cs
Original file line number Diff line number Diff line change
Expand Up @@ -297,10 +297,6 @@ public byte? ItemID4

public override void Dispose()
{
while (!_populated)
{
// Do nothing until population is complete, fixing API enumeration errors
}
_files.Remove(ModuleID);
base.Dispose();
}
Expand Down Expand Up @@ -372,7 +368,6 @@ public override bool OnInitialize()

private int[] _itemIDOffsets;

private bool _populated = false;
public override void OnPopulate()
{
_sections = new ModuleSectionNode[_numSections];
Expand Down Expand Up @@ -455,7 +450,6 @@ public override void OnPopulate()
watch.Stop();
Console.WriteLine("Took {0} seconds to relocate {1} module", watch.ElapsedMilliseconds / 1000d, Name);
_populated = true;
};

using (BackgroundWorker b = new BackgroundWorker())
Expand Down

0 comments on commit f0d2be6

Please sign in to comment.