Translate changelog for 1.2.3 #17
Conversation
* A few more tweaks to the game strings * Translated and finalized the Agsharp strings * Fixed the wrong culture keys in all 4 po files
Added missing English translation for the "Loading..." string when loading a recording into the built-in player.
* Fixed the last remaining errors and typos, including in-game strings. * Rephrased some sentences to sound more natural and/or to better explain the concept, including in-game strings. * Made sure all terms, like skill names, are consistent with the in-game strings. * Reworded everything to address the player informally in the second person of singular, for consistency with in-game strings. I now consider the entire translation to be finalized, tested and ready for production.
* Latest versions of the translated docs from my fork didn't seem to make it into the game update, even though I included them in the pull request before 1.2.3. Please merge this commit in a future patch. Not urgent.
|
Validation and conversion completed without errors, let's wait for the review team. |
|
There are some strange things in the master branch, I’ll review it tomorrow and figure out what got lost and where. |
|
Validation and conversion completed without errors, let's wait for the review team. |
|
Validation and conversion completed without errors, let's wait for the review team. |
|
Hello @4sensegaming, |
|
I'm really sorry about that! In my excuse, I'm only just getting started with Github and Git repositories and this is the first one I've ever collaborated on, so it's all still new to me. I'll make sure this doesn't happen in the future. |
|
Actually, @Danstiv let me close this pull request and make a new one instead. I've made a couple more tweaks on my end in the meantime. |
The latest versions of the translated docs didn't seem to make it into the patch, even though I did include them in my last pull request. Please, merge all po files in their current state from my branch into master in a future patch. Not urgent. The translation works, it's just cosmetic and stylistic changes that didn't seem to make it into the 1.2.3 update.