Fix false positive when parsing with PHP_CodeSniffer #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See PHPCompatibility.Miscellaneous.ValidIntegers.HexNumericStringFound: https://www.zend.com/php-migration/misc/hex-numeric-string
|
I opened an issue for this: PHPCompatibility/PHPCompatibility#1345 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we run PHP_CodeSniffer (phpcs) across our codebase and one of the projects in our codebase uses your asn1 library.
phpcs is throwing a
PHPCompatibility.Miscellaneous.ValidIntegers.HexNumericStringFoundnotice for a small part of your code.After reading up about this notice here:
https://www.zend.com/php-migration/misc/hex-numeric-string
It looks like this is a false positive, so what I've done in this PR is add a rule to disable this specific notice from phpcs. See https://github.com/squizlabs/PHP_CodeSniffer/wiki/Advanced-Usage#ignoring-parts-of-a-file
Let me know if you have any questions.