fix: 버그 수정

- requestParam -> pathVariable로 변경 - dto 필드 순서 변경 - join 조건 추가 related issue #548
sopt-makers · Nov 12, 2024 · fa6a6b1 · fa6a6b1
1 parent e4f977a
commit fa6a6b1
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/main/java/org/sopt/makers/internal/controller/InternalOpenApiController.java b/src/main/java/org/sopt/makers/internal/controller/InternalOpenApiController.java
@@ -158,7 +158,7 @@ public ResponseEntity<InternalRecommendMemberListResponse> getMyRecommendList (
     @Operation(summary = "회원 프로필 및 활동 정보 조회 API")
     @GetMapping("members/{memberId}/project")
     public ResponseEntity<InternalMemberProjectResponse> getMemberProject(
-            @RequestParam Long memberId
+            @PathVariable Long memberId
     ) {
         Member member = memberService.getMemberById(memberId);
         int count = projectService.getProjectCountByMemberId(memberId);
@@ -317,7 +317,7 @@ private void sortProfileCareer (InternalMemberProfileSpecificResponse response)
                     [대분류] 전체, 자유, 파트, SOPT 활동, 취업/진로, 홍보 \n
                     * 각 대분류의 소분류로도 조회 가능합니다. 
             """)
-    @GetMapping("/community/post/{category}/recent")
+    @GetMapping("/community/post/recent")
     public ResponseEntity<InternalCommunityPost> getRecentPostByCategory (
             @RequestParam String category
     ) {

diff --git a/...rg/sopt/makers/internal/member/repository/coffeechat/dto/InternalCoffeeChatMemberDto.java b/...rg/sopt/makers/internal/member/repository/coffeechat/dto/InternalCoffeeChatMemberDto.java
@@ -6,13 +6,13 @@
 
 public record InternalCoffeeChatMemberDto(
 		Long id,
-		List<String> parts,
 		String name,
+		List<String> parts,
 		String profileImage
 ) {
 	public static InternalCoffeeChatMemberDto of(Member member, List<String> parts) {
 		return new InternalCoffeeChatMemberDto(
-				member.getId(), parts, member.getName(), member.getProfileImage()
+				member.getId(), member.getName(), parts, member.getProfileImage()
 		);
 	}
 }
diff --git a/src/main/java/org/sopt/makers/internal/repository/MemberProfileQueryRepository.java b/src/main/java/org/sopt/makers/internal/repository/MemberProfileQueryRepository.java
@@ -369,8 +369,8 @@ public List<Member> findAllMembersByCoffeeChatActivate() {
 
         return queryFactory
                 .selectFrom(member)
-                .join(coffeeChat.member, member)
-                .where(coffeeChat.isCoffeeChatActivate.eq(true))
+                .innerJoin(coffeeChat).on(coffeeChat.member.eq(member))
+                .where(coffeeChat.isCoffeeChatActivate.isTrue())
                 .fetch();
     }
 }