[Fix]: 메이커스 이미지 방지 #536
Merged
[Fix]: 메이커스 이미지 방지 #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to: #535
dev-Crayon
added
high priority
|
jun02160
reviewed
Nov 6, 2024
Comment on lines
49
to
53
| List<AnonymousProfileImage> anonymousProfileImages = anonymousProfileImageRepository.findAll(); | ||
| for (AnonymousProfileImage image : anonymousProfileImages) { | ||
| profileImageMap.put(image.getId(), image); | ||
| if (!image.getId().equals(MAKERS_LOGO_IMAGE_ID)) { | ||
| profileImageMap.put(image.getId(), image); | ||
| } |
There was a problem hiding this comment.
흠 6번만 제외라면 여기서 exclude 하고 쿼리하는 건 별로일까요??
나중에 익명 프로필 이미지 추가되거나 할 때도 쿼리 레벨에서 처리하는 게 더 깔끔해보입니다!
There was a problem hiding this comment.
진짜 베스트 아이디어라고 생각합니다 바로 반영했습니다!
Related to: #535
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #535
🐬 요약
익명 댓글을 작성할 때 메이커스 로고가 선택되는 경우를 방지했습니다.
이미지 목록 Map에 초기화 할 때 id가 6인 이미지는 제외했습니다.
👻 유형
PR의 유형에 맞게 체크해주세요!
🍀 작업 내용
PR에 담긴 작업 내용을 작성해주세요!
🌟 관련 이슈
PR과 관련된 이슈 번호를 작성해주세요!
close: #535