[Chore] 특정 actuator endpoint 허용하도록 security config 설정 추가 #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 모니터링 서버에서 메트릭에 접근 가능하도록 허용하기 위함 related issue #453
|
- for build related issue #453
jun02160
changed the title
dev-Crayon
approved these changes
Nov 21, 2024
Comment on lines
+42
to
43
| .antMatchers("/v3/api-docs/**", "/swagger-ui.html", "/webjars/swagger-ui/**", "/swagger-ui/**", "/makers/**", actuatorEndpoint+"/prometheus", actuatorEndpoint+"/metrics").permitAll() | ||
| .and() |
There was a problem hiding this comment.
빠른 작업 감사합니다. 저번에 슬랙에서 확인해보니 dev가 구글에 검색이 되는 문제도 있고 prod에도 스웨거 경로가 열려있는 문제도 있어서 이부분은 같이 얘기해보면 좋을 것 같습니다!
|
추가로 저희가 actuator를 사용하고 있는데 Actuator를 안전하게 사용하기 위한 설정이 하나도 안되어 있는 것 같습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐬 요약
Actuator 활성화에 대한 보안 설정을 위해 application.yml에서 default endpoint를 변경하고, /prometheus와 /metrics만 선택적으로 전체 접근 허용하도록 Security Config에서 설정을 추가합니다.
👻 유형
PR의 유형에 맞게 체크해주세요!
🍀 작업 내용
PR에 담긴 작업 내용을 작성해주세요!
🌟 관련 이슈
PR과 관련된 이슈 번호를 작성해주세요!
related issue #453