Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] coffee chat 최신순 정렬 추가 #558

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Conversation

jun02160
Copy link
Member

🐬 요약

회의 때 논의된 요청사항에 따라 전체 커피챗 리스트의 최신순 정렬 기능을 추가합니다.

👻 유형

PR의 유형에 맞게 체크해주세요!

  • 버그 수정
  • 기능 개발
  • 코드 스타일 수정 (formatting, local variables)
  • 리팩토링 (no functional changes, no api changes)
  • 빌드 관련 변경사항
  • CI 관련 변경사항
  • CD 관련 변경사항
  • 문서 내용 변경
  • Release
  • 기타... (다음 줄에 사유를 입력해주세요)

🍀 작업 내용

PR에 담긴 작업 내용을 작성해주세요!

  • 작업 1
  • 작업 2
  • 작업 3

🌟 관련 이슈

PR과 관련된 이슈 번호를 작성해주세요!

close: #557

Copy link

height bot commented Nov 24, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@jun02160 jun02160 requested a review from dev-Crayon November 24, 2024 09:34
@jun02160 jun02160 self-assigned this Nov 24, 2024
@jun02160 jun02160 added ✅ Chore 자잘한 수정 시 사용합니다. ✨Feature 새로운 기능 개발시 사용합니다 예준🐈 예준이 연 PR, Issue에 사용 and removed ✅ Chore 자잘한 수정 시 사용합니다. labels Nov 24, 2024
@@ -96,6 +96,7 @@ public List<CoffeeChatInfoDto> findSearchCoffeeChatInfo(Long memberId, CoffeeCha
.leftJoin(member).on(coffeeChat.member.id.eq(member.id))
.leftJoin(memberCareer).on(coffeeChat.member.id.eq(memberCareer.memberId))
.where(builder)
.orderBy(coffeeChat.createdAt.desc())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른작업 감사합니다! LGTM

@jun02160 jun02160 merged commit 2d3bd79 into develop Nov 30, 2024
1 check passed
@jun02160 jun02160 deleted the feat/coffee_chat_sort branch November 30, 2024 02:05
jun02160 added a commit that referenced this pull request Dec 15, 2024
* feat: coffee chat 최신순 정렬 추가 (#558)

related issue #557

* [Feat] update dev server deploy script (#562)

* feat: update dev server deploy script

related issue #561

* fix: aws access key 수정

related issue #561

* fix: ecr login command

related issue #561

* fix: remove 'amd64' tag

related issue #561

* fix: remove 'amd64' tag

related issue #561

* fix: ECR_REPO env를 사용하도록 수정

related issue #561

* fix: env 할당 방식 변경

related issue #561

* fix: env 할당 방식 변경

related issue #561

* fix: change platform

related issue #561

* fix: ECR_REPO env 추가

related issue #561

* chore: ecr repo rollback

* fix: ECR_HOST, ECR_REPO env 변경

* fix: ECR_HOST, ECR_REPO env 변경

* fix: cli만 사용하도록 변경

* fix: directory 명시

* fix: scp debugging

- directory 수정

* fix: env 수정

* fix: docker -> docker-compose로 수정

* fix: docker -> docker-compose로 수정

- scp debug mode off

related issue #561

* feat: port switching 추가

related issue #561

* fix: add health check sleep

related issue #561

* refactor: script 공통 로직 function으로 최소화

related issue #561

* refactor: script 파일 분리

related issue #561

* fix: health check error

related issue #561

* chore: test용 trigger 제거

related issue #561

* feat: apply to production workflow

related issue #561

* chore: remove appspec.yml, code deploy script

related issue #561

* chore: workflow name rollback

related issue #561

* chore: region 'ap-northeast-2'로 변경

related issue #561

* chore: add end line

related issue #561

* test: trigger 추가

related issue #561

* fix: ap-northeast-2 -> us-east-1 로 변경

related issue #561

* chore: remove trigger for test

related issue #561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨Feature 새로운 기능 개발시 사용합니다 size/XS 예준🐈 예준이 연 PR, Issue에 사용
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 커피챗 리스트 최신순 정렬
2 participants