feat: 커피챗 메일 발송 가능하도록 수정 #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- request validation 추가 - sender return 조건 수정
|
dev-Crayon
reviewed
Dec 28, 2024
Comment on lines
+16
to
+23
| public MessageSender getSender(String senderEmail, String senderPhone) { | ||
| if (senderEmail != null) { | ||
| return emailChatSender; | ||
| } | ||
| if (senderPhone != null) { | ||
| return smsChatSender; | ||
| } | ||
| return null; |
There was a problem hiding this comment.
들여쓰기가 8칸 같은데 4칸으로 맞춰주시면 좋을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐬 요약
쪽지 보내기 API에서 커피챗 카테고리에 대해서도 메일 발송이 가능하도록 sender 구현체 판단 조건을 수정합니다.
👻 유형
PR의 유형에 맞게 체크해주세요!
🍀 작업 내용
🌟 관련 이슈
PR과 관련된 이슈 번호를 작성해주세요!
close: #569