Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix division by zero in pricing-import-service #86

Merged
merged 6 commits into from
Feb 1, 2024
Merged

Fix division by zero in pricing-import-service #86

merged 6 commits into from
Feb 1, 2024

Conversation

bragov4ik
Copy link
Contributor

No description provided.

@bragov4ik bragov4ik self-assigned this Jan 31, 2024
@bragov4ik bragov4ik linked an issue Jan 31, 2024 that may be closed by this pull request
@bragov4ik bragov4ik requested a review from vovac12 January 31, 2024 13:12
@f33r0 f33r0 requested review from f33r0 and vovac12 and removed request for vovac12 January 31, 2024 13:12
@bragov4ik bragov4ik requested a review from wer1st January 31, 2024 13:13
@bragov4ik
Copy link
Contributor Author

bragov4ik commented Jan 31, 2024

I'm not sure whether it's correct to quote in the other direction instead of $1/amount$ (might be different buy/sell prices??).
Anyway, my reasoning was that if the aim is to find price A -> B, then using quote(A -> B) makes sense more than 1/quote(B -> A)

@bragov4ik bragov4ik merged commit 561827a into master Feb 1, 2024
3 checks passed
@bragov4ik bragov4ik deleted the 85-fix branch February 1, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pricing-import-service restarts
3 participants