Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded VAL supply removed #162

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

bgodlin
Copy link
Contributor

@bgodlin bgodlin commented Aug 18, 2023

The link that shows the supply dynamically can be found closer to the end of the page

The link that shows the supply dynamically can be found closer to the end of the page
@bgodlin bgodlin linked an issue Aug 18, 2023 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Aug 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
sora-docs ✅ Ready (Inspect) Visit Preview Aug 20, 2023 11:00am

Copy link
Contributor

@Tieumsan Tieumsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to leave the total supply as it's a FAQ. We can only remove the "currently circulating supply" part and redirect to Polkaswap or https://sora-qty.info/.

Although the supply reported is different on those 2 resources

@bgodlin
Copy link
Contributor Author

bgodlin commented Aug 20, 2023

https://sora-qty.info/

The website mentioned above fetched data from the URL of the mof3 node mentioned in the documentation. For the time being, I suggest maintaining this URL as a single source of truth.

@bgodlin bgodlin merged commit 949cf81 into develop Aug 21, 2023
1 check passed
@bgodlin bgodlin deleted the 137-dynamic-supplies-instead-of-the-hardcoded-values branch August 21, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic supplies instead of the hardcoded values
4 participants