Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substrate bridge documentation #44

Merged
merged 59 commits into from
Oct 30, 2023
Merged

Conversation

bgodlin
Copy link
Contributor

@bgodlin bgodlin commented May 31, 2023

No description provided.

@bgodlin bgodlin closed this May 31, 2023
@bgodlin bgodlin reopened this May 31, 2023
@bgodlin bgodlin linked an issue May 31, 2023 that may be closed by this pull request
@bgodlin bgodlin self-assigned this May 31, 2023
src/hashi.md Outdated Show resolved Hide resolved
src/hashi.md Outdated Show resolved Hide resolved
src/interoperability.md Outdated Show resolved Hide resolved
src/interoperability.md Outdated Show resolved Hide resolved
src/interoperability.md Outdated Show resolved Hide resolved
src/substrate-bridge.md Outdated Show resolved Hide resolved
src/substrate-bridge.md Outdated Show resolved Hide resolved
src/substrate-bridge.md Outdated Show resolved Hide resolved
src/substrate-bridge.md Outdated Show resolved Hide resolved
src/substrate-bridge.md Outdated Show resolved Hide resolved
Copy link
Contributor

@WRRicht3r WRRicht3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the suggestions in the text.
Thank you
WR

@bgodlin bgodlin requested a review from N1ghtStorm May 31, 2023 16:54
@vercel
Copy link

vercel bot commented Jun 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sora-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 1:43pm
sora-docs-oge3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 1:43pm

@vercel vercel bot temporarily deployed to Preview – sora-docs June 9, 2023 06:52 Inactive
bgodlin and others added 2 commits October 16, 2023 15:51
Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
@WRRicht3r
Copy link
Contributor

The Queen is back


The Federated Bridge in SORA relies on the following pallets:

- **BridgeDataSigner**: Developed by SORAMITSU ([source code](https://github.com/sora-xor/sora2-common/tree/develop/pallets/data-signer)). This pallet is responsible for signing bridge data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually relayer sign the messages. BridgeDataSigner is responsible for collecting signatures from different relayers and checks that message is signed by valid peer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Root extrinsics: `registerNetwork`, `addPeer`, `removePeer`, `submit`.
Messages: see [`BridgeCall` enum](https://github.com/sora-xor/sora2-common/blob/2f0aeec218e7646c295f371c4f553f4260e59eff/pallets/types/src/substrate.rs#L126)

- **MultisigVerifier**: Developed by SORAMITSU ([source code](https://github.com/sora-xor/sora2-common/tree/develop/pallets/multisig-verifier)). This pallet manages the verification of peers and ECDSA signatures. It utilizes BeefyLightClient for message verification and SubstrateDispatch for message calling.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InboundChannel uses this pallet or BeefyLightClient for message verification and SubstrateDispatch to decode and dispatch bridge Calls. And this pallet works independently from BeefyLightClient and SubstrateDispatch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


#### Other Parachain -> SORA mainnet

Example extrinsic: https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Fws.karura-node-1.c2.dev.sora2.soramitsu.co.jp#/extrinsics/decode/0x3600008000407a10f35a00000000000000000000010102006d1f0100e6cacc509b47920b3fe9329224df74640cd6861d40132633aae46c168ab73e4d00
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not share private dev environment enpoints in docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Ekaterina Mekhnetsova <[email protected]>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we renamed substrateBridgeApp to parachainBridgeApp

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already addressed

@bgodlin bgodlin merged commit 9bc381a into develop Oct 30, 2023
2 checks passed
@bgodlin bgodlin deleted the 7-substrate-bridge-documentation branch October 30, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] Write article in wiki for Parachain Bridge Public Test Substrate bridge documentation
9 participants