-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Substrate bridge documentation #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the suggestions in the text.
Thank you
WR
Co-authored-by: William Richter <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
The Queen is back |
Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
src/substrate-bridge.md
Outdated
|
||
The Federated Bridge in SORA relies on the following pallets: | ||
|
||
- **BridgeDataSigner**: Developed by SORAMITSU ([source code](https://github.com/sora-xor/sora2-common/tree/develop/pallets/data-signer)). This pallet is responsible for signing bridge data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually relayer sign the messages. BridgeDataSigner
is responsible for collecting signatures from different relayers and checks that message is signed by valid peer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/substrate-bridge.md
Outdated
Root extrinsics: `registerNetwork`, `addPeer`, `removePeer`, `submit`. | ||
Messages: see [`BridgeCall` enum](https://github.com/sora-xor/sora2-common/blob/2f0aeec218e7646c295f371c4f553f4260e59eff/pallets/types/src/substrate.rs#L126) | ||
|
||
- **MultisigVerifier**: Developed by SORAMITSU ([source code](https://github.com/sora-xor/sora2-common/tree/develop/pallets/multisig-verifier)). This pallet manages the verification of peers and ECDSA signatures. It utilizes BeefyLightClient for message verification and SubstrateDispatch for message calling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
InboundChannel uses this pallet or BeefyLightClient for message verification and SubstrateDispatch to decode and dispatch bridge Calls. And this pallet works independently from BeefyLightClient and SubstrateDispatch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/substrate-bridge.md
Outdated
|
||
#### Other Parachain -> SORA mainnet | ||
|
||
Example extrinsic: https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Fws.karura-node-1.c2.dev.sora2.soramitsu.co.jp#/extrinsics/decode/0x3600008000407a10f35a00000000000000000000010102006d1f0100e6cacc509b47920b3fe9329224df74640cd6861d40132633aae46c168ab73e4d00 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should not share private dev environment enpoints in docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we renamed substrateBridgeApp to parachainBridgeApp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was already addressed
No description provided.