Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front end enhancements needs and suggestions #15

Open
abalioni opened this issue Jan 28, 2019 · 11 comments
Open

Front end enhancements needs and suggestions #15

abalioni opened this issue Jan 28, 2019 · 11 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@abalioni
Copy link

Leave here your requests, needs and suggestions for the front end.

@rfschubert
Copy link

I think few improvments are:

  • Labels on inputs.
  • Small description of what is the site for

The screen is just a map with 2 inputs and a button. Doesn't tell much about what it was designed for.

@brunocroh brunocroh added enhancement New feature or request help wanted Extra attention is needed labels Jan 28, 2019
@Isaachi1
Copy link

Maybe it's a good idea to let the map where the mud avalanche has passed. And the app has to be something very simple, without many buttons and tals. With labels and inputs with a design that is easy to identify by the user, because at the time of the race runs could be that it hinders the visibility. And the description of the places is very visible too. My sugestion. 😅

@guilhermearmelo
Copy link
Contributor

I think creating /css and /js folderss make the hole project to be slower, even minifying files. It's better just import bootstrap library with:
CSS
<link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/bootstrap/4.2.1/css/bootstrap.min.css" integrity="sha384-GJzZqFGwb1QTTN6wy59ffF1BuGJpLSa9DkKMp0DgiMDm4iYMj70gZWKYbI706tWS" crossorigin="anonymous">

JS

<script src="https://code.jquery.com/jquery-3.3.1.slim.min.js" integrity="sha384-q8i/X+965DzO0rT7abK41JStQIAqVgRVzpbzo5smXKp4YfRvH+8abtTE1Pi6jizo" crossorigin="anonymous"></script>

<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.14.6/umd/popper.min.js" integrity="sha384-wHAiFfRlMFy6i5SRaxvfOCifBUQy1xHdJ/yoi7FRNXMRBu5WHdZYu1hA6ZOblgut" crossorigin="anonymous"></script>

<script src="https://stackpath.bootstrapcdn.com/bootstrap/4.2.1/js/bootstrap.min.js" integrity="sha384-B0UglyR+jN6CkvvICOB2joaf5I4l3gm9GU6Hc1og6Ls7i6U/mkkaduKaBhlAXv9k" crossorigin="anonymous"></script>

@avlm
Copy link

avlm commented Jan 28, 2019

what about a page with official places for gathering donations, sorted by state/city. Someone sent to the whatsapp group that people are sharing fake donation places.

@qgustavor
Copy link
Contributor

qgustavor commented Jan 28, 2019

As I said on #23, some ideas:

  • Rename the Leaflet tutorial title...
  • Stylesheets could use CDNs, like scripts (the main issue from Getting Bootstrap #23);
  • Inline styles and scripts could be moved to their own files.
  • border-radius doesn't need vendor prefixes, so those can be removed.
  • There are some unused variables on the website code, like this one.

I can send a pull request fixing the above points, but I also have some questions:

  • How about using a linter?
  • Is it OK to keep using modern JavaScript features (like async/await and fetch)?
  • If the website becomes complex try to keep it "vanilla" or use some library?

In most of my projects I like using Vue (which I think it's easy to learn and is also "incrementally adoptable", something like "no build process required, just add a <script> tag") and Standard (which some people might not like because it avoids semicolons... but, well, Python don't use those).

But those are my personal preferences, I can try to keep using the same code style if you prefer. Current code just uses Bootstrap CSS and Leaflet (so... no jQuery). The code style uses both single quotes and double quotes. Python and JavaScript code uses four spaces for indentation (so it's better to avoid Standard, which uses two spaces).

About the design how about something like this? https://wireframe.cc/RGczK7

@waghcwb
Copy link

waghcwb commented Jan 28, 2019

If the technology used is vue I can help with the frontend too..

@guilhermearmelo
Copy link
Contributor

I can help on frontend too

@guifelix
Copy link

@guifelix
Copy link

another suggestion is to use Tailwind

@eduardolomb
Copy link

I don't know whether a 2D map would be better for machines with fewer resources (like tablets and mobile phones). People should be able to use it on site...

@qgustavor
Copy link
Contributor

qgustavor commented Jan 30, 2019

Is someone working on internationalization? The current, non-functional, language switcher was made with something like vue-i18n in mind. In the other hand, as now Django is being used, other choice can be using django.utils.translation. Seems using Django features will make it easier for most people. It also support catalogs which will help translating strings on script.js, like "Localização inicial" and "Localização selecionada".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

10 participants