Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Bootstrap #23

Closed
guilhermearmelo opened this issue Jan 28, 2019 · 4 comments
Closed

Getting Bootstrap #23

guilhermearmelo opened this issue Jan 28, 2019 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@guilhermearmelo
Copy link
Contributor

Try getting bootstrap from getbootstrap.com
Add:

on index.html. The css folder is not making the app faster, but slower.

@brunocroh brunocroh added enhancement New feature or request good first issue Good for newcomers labels Jan 28, 2019
@qgustavor
Copy link
Contributor

I think the website could be reworked in some ways:

  • Rename the Leaflet tutorial title...
  • Stylesheets could use CDNs, like scripts.
  • Inline styles and scripts could be moved to their own files.
  • border-radius doesn't need vendor prefixes, so those can be removed.
  • There are some unused variables on the website code, like this one.

I can send a pull request fixing the above points, but I also have some questions:

  • How about using a linter?
  • Is it OK to keep using modern JavaScript features (like async/await and fetch)?
  • If the website becomes complex try to keep it "vanilla" or use some library?

In most of my projects I like using Vue (which I think it's easy to learn and is also "incrementally adoptable") and Standard (which some people might not like because it avoids semicolons... but, well, Python don't use those). But those are my personal preferences, I will try to keep using the same code style if you prefer.

@glauberfc
Copy link

I think React can be a good choice

@qgustavor
Copy link
Contributor

qgustavor commented Jan 28, 2019

@glauberfc I'm fine with React, but I find Vue's "incrementally adoptable" good for this project as we can just add a <script> for now instead of requiring a build step to compile JSX or having to avoid it.

Edit: can I use Standard (or even Semi-Standard)?

Edit 2: I just noticed that #15 would be a better place to place those ideas.

@vaniaon
Copy link
Member

vaniaon commented Jan 29, 2019

Guys,

Since now we have a list of independents projects, I think we can use frontend technologies that the first front dev who take the project are more familiar with. The idea is using microservices and devops technologies for integrate them.
As I wrote in the readme, once you are working on a project, this put a comment there for everyone know.

I am closing this issue.

@vaniaon vaniaon closed this as completed Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants