Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maas] fix working directory for rsyslog configs on snap install #3445

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

adam-vest
Copy link
Contributor


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3445
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@TurboTurtle
Copy link
Member

Sanity question - was this always wrong, or has it recently changed? Is there a possible (valid) use case for both and we should try to collect each location, knowing that only one is likely to exist on any given host?

@adam-vest
Copy link
Contributor Author

Heh, I was wondering if this question would pop up. I'm honestly not sure if it's always been wrong, but I checked against all versions that are shipped in the snap store (which goes back to 2.7), and all of those have the directory named syslog, and not rsyslog. 3.0 is also the oldest version that's supported currently, so while it's certainly possible that this is a legacy naming convention, it would have been on versions that are no longer officially available or supported, going back at least 3 years.

@TurboTurtle
Copy link
Member

Works for me as-is then.

@TurboTurtle TurboTurtle merged commit af139c4 into sosreport:main Dec 15, 2023
33 checks passed
@adam-vest adam-vest deleted the maas-syslog branch December 15, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants