Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[atomic] Remove atomic policy #3451

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

jcastill
Copy link
Member

RHEL Atomic Host is RHEL7 only, and we since
we don't ship sos 4.* in RHEL 7, we can drop
this policy.


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3451
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@pmoravec
Copy link
Contributor

Generally ACK, but isn't also AtomicHost class plugin (whole sos/report/plugins/atomichost.py) obsolete..?

@jcastill
Copy link
Member Author

I thought about removing it as well, but then I doubted because we've never removed a plugin as far as I know, and I didn't know if there's a corner case where we could still get this plugin to work. But if you think there's no such case, I'll update the PR removing it as well.

@pmoravec
Copy link
Contributor

Per https://access.redhat.com/solutions/4813941 , Atomic Host is EOL and on RHEL7 only.

@TurboTurtle, any thought about removing plugin?

@TurboTurtle
Copy link
Member

I'll defer to you on removal of the plugin, but given the history of Atomic Host I don't have any concerns about removing it personally.

RHEL Atomic Host is RHEL7 only, and we since
we don't ship sos 4.* in RHEL 7, we can drop
this policy and the associated sos plugin.

Signed-off-by: Jose Castillo <[email protected]>
@jcastill jcastill force-pushed the jcastillo-drop-atomic-policy branch from b292ef5 to 9ac55ac Compare January 8, 2024 09:34
@TurboTurtle TurboTurtle merged commit 52baa9b into sosreport:main Jan 22, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants