Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] Add debian to standard testing #3907

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arif-ali
Copy link
Member

@arif-ali arif-ali commented Jan 16, 2025

  • Add new debian_only to replace current ubuntu_only.
  • ubuntu_only now only tests true for only Ubuntu distros.
  • Add extra packages to install for Debian ditsros, as these are not installed by default.

As per discussions in the maintainer call, wanted to start testing more on Debian, and this is a first start on testing debian regularly


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3907
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@arif-ali
Copy link
Member Author

I'm trying to figure out what is wrong here. Tried to bring up the shell on Cirrus, and run the same command as the config, and all works. Maybe I am missing something, and I can't see it clearly and stared at it for a bit. A second head might see the issue if anyone wants to look at the PR

'Ubuntu': 'cups'}
packages = {
'rhel': 'cups',
'Ubuntu': 'cups',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see sometimes packages['Ubuntu'] and sometimes packages['ubuntu'] declared. While distro checking is case sensitive, I think..?

This PR does not change the case sensitivity on either place, but maybe it reveals the problem behind it..?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the Report Stage One - ubuntu-24.10 - deb is not even getting to that point, it's as if it's not even running the if statement or is coming out as false, and hence not completing the setup

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I dont understand the error. How it could ever attempt to run apt -y install sosreport if that package/file name (for apt) is never mentioned..?

@arif-ali arif-ali force-pushed the sos-arif-debian-ci branch 3 times, most recently from a3a1063 to f1df9d8 Compare January 20, 2025 22:18
* Add new debian_only to replace current ubuntu_only.
* ubuntu_only now only tests true for only Ubuntu distros.
* Add extra packages to install for Debian ditsros, as these are not installed
  by default.
* python3-yaml is not in the default image, and required for sunbeam plugin and
  saltstack collect plugins.

Signed-off-by: Arif Ali <[email protected]>
@arif-ali arif-ali marked this pull request as ready for review January 21, 2025 07:13
@arif-ali arif-ali added Status/Needs Review This issue still needs a review from project members Kind/Testing Related to Testing labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind/Testing Related to Testing Status/Needs Review This issue still needs a review from project members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants