-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support webpack 4.8+ #59
base: master
Are you sure you want to change the base?
Conversation
outshineamaze
commented
May 25, 2018
- modify : return _.replace(""CHUNK_MANIFEST"",..... line 63
- add compilation.mainTemplate.hooks.assetPath ..... line 33
This would be super useful to get merged 🚀 |
Do we have any alternatives until this is merged? |
@diurnalist @bruderstein @spadgos @shakyShane @brandondoran @matthiasfeist @gingur @soundcloud/web-collective, @janizde and @MarinaFroes Can we get someone to look at this pr (or #56 #63, #64) or add some new maintainers... Lots of people blocked and no communication :\ |
I can see if we can get this merged. I'll also try and update the status - we no longer use this internally, as contenthash is now significantly better than it used to be. |
@niemyjski are you able to confirm that this works in 4.8+? |
@bruderstein Thanks, I just started to look at the various pr's to figure out which one is the best one and then I was going to test. Thanks for the reply, Makes me wonder if we should update the readme to state that with a snippet or steps to upgrade to content hash. I have a large project that is out of date and I'm just trying to get it to work on latest before I go changing things out. |
Just a quick update - I'd got two plugins mixed up when I said "we no longer use this internally, as contenthash is now significantly better than it used to be." - sorry, doing too many things concurrently! We do no longer use this, but I think it's because since webpack 4, module_ids are more stable, so things are generally better. Webpack 5 improves this further with hashed module_ids, making them more stable. |