-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated and created a new settings page with IOS like dropdown menus #122
base: main
Are you sure you want to change the base?
Conversation
// Section Descriptions | ||
private static let sectionDescriptions: [Section: String] = [ | ||
.general: "General settings for the app.", | ||
.audio: "Control how audio interacts with other media.", | ||
.callouts: "Manage the callouts that help navigate.", | ||
.streetPreview: "Settings for including unnamed roads.", | ||
.troubleshooting: "Options for troubleshooting the app.", | ||
.about: "Information about the app.", | ||
.telemetry: "Manage data collection and privacy." | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These strings will need to be localized, so they should go into the English localization file (under Assets/Localization), and be referenced by a call to GDALocalizedString
where they are used.
Hi. I just tested this on my phone. It isn't really working well with Voiceover unfortunately. I mean it does work but is a bit confusing. VO reports General as a heading and you have to tap on it to expand it. I'm not really sure what the original issue was about exactly, but this doesn't feel like the iOS settings app, at least with Voiceover. I also got the following from the debugger when collapsing the general section:
|
Hi, I made some changes to the settings page, I included the audio beacon section that ryan worked on before. Additionally it seems that if we want to have each section open up to a new page, it would require making separate controllers for each expanded section underneath the general one. I did manage to get callouts to open to a new page but I would like someone to look into if it works completely. As for the thread error, I have been looking diligently into it but am not quite sure how to fix it as it only happens every now and then and when it does pop up it is inconsistent with what action causes it, such expanding a section or closing a section or opening too many sections or navigating too fast. |
No description provided.