Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated and created a new settings page with IOS like dropdown menus #122

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

MBtheOtaku
Copy link

No description provided.

Comment on lines 67 to 76
// Section Descriptions
private static let sectionDescriptions: [Section: String] = [
.general: "General settings for the app.",
.audio: "Control how audio interacts with other media.",
.callouts: "Manage the callouts that help navigate.",
.streetPreview: "Settings for including unnamed roads.",
.troubleshooting: "Options for troubleshooting the app.",
.about: "Information about the app.",
.telemetry: "Manage data collection and privacy."
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These strings will need to be localized, so they should go into the English localization file (under Assets/Localization), and be referenced by a call to GDALocalizedString where they are used.

@RDMurray
Copy link
Contributor

Hi. I just tested this on my phone. It isn't really working well with Voiceover unfortunately. I mean it does work but is a bit confusing. VO reports General as a heading and you have to tap on it to expand it.

I'm not really sure what the original issue was about exactly, but this doesn't feel like the iOS settings app, at least with Voiceover.

I also got the following from the debugger when collapsing the general section:

Thread 1: "Invalid batch updates detected: the number of sections and/or rows returned by the data source before and after performing the batch updates are inconsistent with the updates.\nData source before updates = { 7 sections with row counts: [6, 0, 0, 1, 0, 0, 0] }\nData source after updates = { 7 sections with row counts: [6, 0, 0, 0, 0, 0, 0] }\nUpdates = [\n\tDelete section 0,\n\tInsert section 0\n]\nTable view: <UITableView: 0x10af19c00; frame = (0 91; 390 753); clipsToBounds = YES; autoresize = W+H; tintColor = <UIDynamicCatalogColor: 0x3037a0aa0; name = Foreground 1>; gestureRecognizers = <NSArray: 0x301bcc630>; backgroundColor = <UIDynamicCatalogColor: 0x30372afd0; name = Background Base>; layer = <CALayer: 0x30122c4c0>; contentOffset: {0, 0}; contentSize: {390, 818.33333333333326}; adjustedContentInset: {0, 0, 34, 0}; dataSource: <Soundscape.SettingsViewController: 0x114ab4a00>>"

@MBtheOtaku
Copy link
Author

Hi, I made some changes to the settings page, I included the audio beacon section that ryan worked on before. Additionally it seems that if we want to have each section open up to a new page, it would require making separate controllers for each expanded section underneath the general one. I did manage to get callouts to open to a new page but I would like someone to look into if it works completely. As for the thread error, I have been looking diligently into it but am not quite sure how to fix it as it only happens every now and then and when it does pop up it is inconsistent with what action causes it, such expanding a section or closing a section or opening too many sections or navigating too fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants