-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge work done by openscape and soundscape for everyone #42
Conversation
Not part of any active workflow, but good to surface the option in case we get to the point of needing it.
…so other developers can build with the same code signing identity
… step which seems to fix errors storing credentials temporarily (much less annoying, but probably needs to be updated to act differently on CI, creating a new keychain there)
…ting the archive; change the code signing identity in Xcode to use the one created by match
I added comments to help get people set up with this; in short: get sentry-cli, sentry-cli login --url https://sentry.openscape.io
…st outputs, etc) - they should never be commited
…etup steps if fastlane beta is run in a CI environment
…ill create a changelog in the future and upload to testflight on PRs or commits to main; disable our existing ios.yaml
This will manually set the build number for everything, even places that used a variable before.
These will likely be used most in other lanes later on, but can still be useful for developers.
…github secret This addresses part of the issue where CI machines are unable to authenticate to our private repository to obtain the certificates and profiles needed for code signing.
The continuous integration (via Github actions) requires that our build machine be able to check out our private certificates repository, managed by fastlane's Match. To allow for this, I will create a Github Machine User, who only has one ssh key added to the account. I'll then add this as a deploy key to the certificates repository and the private portion will be placed in a github secret that builders can access. See the Fastlane match documentation linked above for the rationale behind this. |
…or soundscape.services
…vices.soundscape Building with this change means we can no longer push builds to Openscape on testflight, as the bundle ID is different.
…d for other developers
Share links aren't yet working, pending the subdomain and associated domains file.
Just downloaded the new TestFlight build. Assuming this is using the new backend servers, they seem to be working nicely based on some limited testing. Sweet! I noticed the icons are still Openscape's. I can update these if you haven't gotten to this yet. |
Can we merge this into main? Even if we expect there are more changes, if we're already releasing builds from it, I think it should be part of the main branch at this point. |
Wrap some calls in DispatchQueue.main.async { ... } per https://developer.apple.com/documentation/xcode/diagnosing-memory-thread-and-crash-issues-early
Sorry I missed this comment; thanks for the merge. |
This PR merges in changes made by contributors to Soundscape for Everyone into this repository, for our merge into the Soundscape Community!
Rough overview:
Todo: