Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge work done by openscape and soundscape for everyone #42

Merged
merged 42 commits into from
Aug 23, 2023
Merged

Conversation

Oliver2213
Copy link
Member

This PR merges in changes made by contributors to Soundscape for Everyone into this repository, for our merge into the Soundscape Community!
Rough overview:

  • Integrate a basic Fastfile and fastlane: permits fastlane beta (builds and pushes to app store); bump the major, minor and patch components of the version number; clean inactive testers (period set to one month); download and set up certificates for code signing.
  • Update the github CI action to run fastlane beta on merges and commits to main
  • Update the privacy policy to use the one provided by IA Labs
  • Update to swift 5 (already on main I believe)

Todo:

  • App icons and minor UI fix

Not part of any active workflow, but good to surface the option in case we get to the point of needing it.
…so other developers can build with the same code signing identity
… step which seems to fix errors storing credentials temporarily

(much less annoying, but probably needs to be updated to act differently on CI, creating a new keychain there)
…ting the archive; change the code signing identity in Xcode to use the one created by match
I added comments to help get people set up with this; in short: get sentry-cli, sentry-cli login --url https://sentry.openscape.io
…st outputs, etc) - they should never be commited
…etup steps if fastlane beta is run in a CI environment
…ill create a changelog in the future and upload to testflight on PRs or commits to main; disable our existing ios.yaml
This will manually set the build number for everything, even places that used a variable before.
These will likely be used most in other lanes later on, but can still be useful for developers.
…github secret

This addresses part of the issue where CI machines are unable to authenticate to our private repository to obtain the certificates and profiles needed for code signing.
@Oliver2213
Copy link
Member Author

The continuous integration (via Github actions) requires that our build machine be able to check out our private certificates repository, managed by fastlane's Match. To allow for this, I will create a Github Machine User, who only has one ssh key added to the account. I'll then add this as a deploy key to the certificates repository and the private portion will be placed in a github secret that builders can access. See the Fastlane match documentation linked above for the rationale behind this.

@steinbro
Copy link
Member

Just downloaded the new TestFlight build. Assuming this is using the new backend servers, they seem to be working nicely based on some limited testing. Sweet!

I noticed the icons are still Openscape's. I can update these if you haven't gotten to this yet.

benjamintios and others added 4 commits August 15, 2023 23:09
The logos rendered in the launch and about screens
were being recolored to monochrome. This resulted in
solid white squares. Replaced with SVGs edited to
remove all background shapes.
@steinbro
Copy link
Member

Can we merge this into main? Even if we expect there are more changes, if we're already releasing builds from it, I think it should be part of the main branch at this point.

@steinbro steinbro merged commit 2254dc7 into main Aug 23, 2023
@steinbro steinbro deleted the ssfe-merge branch August 23, 2023 00:40
@Oliver2213
Copy link
Member Author

Sorry I missed this comment; thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants