Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #227
As described in the issue, the
union
operation does not preserve the color of one of the solids when they are non-intersecting. Upon inspection of the JSCAD code, I realized that there is a separate function to handle non-intersecting unions, and thetoPolygons
function was not called with the option of preserving the individual colors of a polygon using the boolean parametercolorizePolygons
. This has been rectified in this PR.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Running the snippet provided in #227
Checklist: