Add DELETE routes #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
ngruiyanrena
approved these changes
Jul 26, 2023
YaleChen299
pushed a commit
that referenced
this pull request
Jul 26, 2023
* Add delete method to user model * Create users' delete controller * Add delete method to story model * Create stories' delete controller * Add TODOs * Update router
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this introduces some deleted-user related bugs, namely #76 and #77. There are also some potential enhancements left as TODOs within the code.
However, this would server the MVP of allowing basic CRUD operations. Also, it is worth noting that deleting a story will not delete its associated author.