Skip to content

Commit

Permalink
test: fix e2e test error codes
Browse files Browse the repository at this point in the history
As these were changed with the openapi decorator the test need to reflect this.

Signed-off-by: Philip Molares <[email protected]>
DerMolly authored and davidmehren committed Feb 20, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
1 parent 89aac9d commit cae55e0
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions test/private-api/auth.e2e-spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: 2021 The HedgeDoc developers (see AUTHORS file)
* SPDX-FileCopyrightText: 2022 The HedgeDoc developers (see AUTHORS file)
*
* SPDX-License-Identifier: AGPL-3.0-only
*/
@@ -236,7 +236,7 @@ describe('Auth', () => {
await request(testSetup.app.getHttpServer())
.delete('/api/private/auth/logout')
.set('Cookie', cookie)
.expect(200);
.expect(204);
});
});
});
4 changes: 2 additions & 2 deletions test/private-api/history.e2e-spec.ts
Original file line number Diff line number Diff line change
@@ -177,7 +177,7 @@ describe('History', () => {
expect(
(await testSetup.historyService.getEntriesByUser(user)).length,
).toEqual(1);
await agent.delete('/api/private/me/history').expect(200);
await agent.delete('/api/private/me/history').expect(204);
expect(
(await testSetup.historyService.getEntriesByUser(user)).length,
).toEqual(0);
@@ -209,7 +209,7 @@ describe('History', () => {
const entryDto = await historyService.toHistoryEntryDto(entry2);
await agent
.delete(`/api/private/me/history/${alias || 'undefined'}`)
.expect(200);
.expect(204);
const userEntries = await historyService.getEntriesByUser(user);
expect(userEntries.length).toEqual(1);
const userEntryDto = await historyService.toHistoryEntryDto(userEntries[0]);
4 changes: 2 additions & 2 deletions test/private-api/me.e2e-spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: 2021 The HedgeDoc developers (see AUTHORS file)
* SPDX-FileCopyrightText: 2022 The HedgeDoc developers (see AUTHORS file)
*
* SPDX-License-Identifier: AGPL-3.0-only
*/
@@ -96,7 +96,7 @@ describe('Me', () => {
.send({
name: newDisplayName,
})
.expect(200);
.expect(201);
const dbUser = await testSetup.userService.getUserByUsername('hardcoded');
expect(dbUser.displayName).toEqual(newDisplayName);
});
4 changes: 2 additions & 2 deletions test/private-api/register-and-login.e2e-spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: 2021 The HedgeDoc developers (see AUTHORS file)
* SPDX-FileCopyrightText: 2022 The HedgeDoc developers (see AUTHORS file)
*
* SPDX-License-Identifier: AGPL-3.0-only
*/
@@ -56,7 +56,7 @@ describe('Register and Login', () => {
expect(profile.body.displayName).toEqual(DISPLAYNAME);

// logout again
await session.delete('/api/private/auth/logout').expect(200);
await session.delete('/api/private/auth/logout').expect(204);

// not allowed to request profile now
await session.get('/api/private/me').expect(401);

0 comments on commit cae55e0

Please sign in to comment.