Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry: Record installation events for all non-Web clients #5763

Closed
wants to merge 3 commits into from

Conversation

abeatrix
Copy link
Contributor

@abeatrix abeatrix commented Sep 30, 2024

CLOSE https://linear.app/sourcegraph/issue/CODY-49/bug-v2-telemetry-for-cody-installations-not-being-fired

I think this might have already been fixed when we update the clientCapabilities().isCodyWeb check to returns false when agentIDE is not set to CodyIDE.Web. Before that change, clientCapabilities().isCodyWeb would always returns true for all IDEs.

We can confirm by enabling E2E tests for logging the installed event and installing Cody in a new machine.

Test plan

  1. Green CI to confirm the cody.extension:installed events are now being logged.
  2. In a new machine, confirm the cody.extension:installed events is logged:

image

█ telemetry-v2: recordEvent: cody.extension/installed  {
  "parameters": {
    "version": 0,
    "billingMetadata": {
      "product": "cody",
      "category": "billable"
    }
  },
  "timestamp": "2024-10-01T16:35:14.262Z"
}

NOTE: The installed event does not fire for users who uninstalled then re-install Cody.

Changelog

@abeatrix abeatrix marked this pull request as draft September 30, 2024 23:33
update expectedV2Events

makes sure anonymousUserID is called

update expected events list

fix event name
@abeatrix abeatrix marked this pull request as ready for review October 1, 2024 15:17
@abeatrix abeatrix changed the title Telemetry: Ensure installation event is recorded for IDE clients Telemetry: Record installation events for all non-Web clients Oct 1, 2024
@abeatrix abeatrix requested review from akalia25, dadlerj, kelsey-brown and a team October 1, 2024 15:34
@akalia25
Copy link
Contributor

akalia25 commented Oct 1, 2024

Thanks @abeatrix! Just a note, that on the VSCode E2E tests, cody.extension.installed has been firing successfully; its being validated on each test's expectedEvents list (ref), that comment on vscode/test/e2e/helpers.ts is an old one from me, sorry for not updating that!

@abeatrix abeatrix removed request for a team, dadlerj and kelsey-brown October 1, 2024 16:08
@abeatrix abeatrix marked this pull request as draft October 1, 2024 17:23
@abeatrix
Copy link
Contributor Author

abeatrix commented Oct 7, 2024

looks like this is already fixed and no longer an issue

@abeatrix abeatrix closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants