Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified prompts: Return inline documentation command #5764

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

vovakulikov
Copy link
Contributor

This PR returns inline documentation code command functionality, We deleted it for unified prompts experience but found that our smart apply can't replace our inline commands fully at the moment (it's still too slow in most of the cases).

So this PR brings back the inline documentation command, but note that documentation code button on the welcome screen still works as a prompt (this is intended) cc @aramaraju

Test plan

  • Check that with the unified-prompts feature flag (currently enabled on s2)
  • You can trigger the inline documentation command by shortcut opt+D and by right-clicking the context menu sub-option.
  • Check that documentation code standard prompt on the welcome screen works

@vovakulikov vovakulikov requested review from thenamankumar and a team September 30, 2024 23:32
@vovakulikov vovakulikov self-assigned this Sep 30, 2024
@vovakulikov vovakulikov merged commit 9dd8283 into main Oct 1, 2024
18 checks passed
@vovakulikov vovakulikov deleted the vk/fix-documentation-command branch October 1, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants