Command: register missing commands when unifiedPrompts is enabled #5768
+177
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, some commands unrelated to the chat commands are not registered when unified prompts feature is enabled, which I believe is unintentional. This PR add some documentations around some cody commands, and refactor the logic to make it clear what the new unified prompts commands are during the command registeration. This PR also fixes the issue where the generate unit test command was unintentionally removed when the unified prompts feature is enabled.
abeatrix
commented
Oct 1, 2024
vscode/src/main.ts
Outdated
| executeAutoEditCommand(a) | ||
| ), | ||
| ] | ||
| ? [...chatCommands, ...editCommands, ...unifiedPromptsCommands] |
There was a problem hiding this comment.
@vovakulikov we are currently registering all the chat commands and edit commands when the feature flag is enabled -- am I understanding this correctly?
abeatrix
commented
Oct 1, 2024
|
|
||
| disposable.push( | ||
| // Command that sends the selected output from the Terminal panel to Cody Chat for explanation. | ||
| vscode.commands.registerCommand('cody.command.explain-output', a => executeExplainOutput(a)), |
There was a problem hiding this comment.
i've seperated these commands out to make sure they will always be registered as they are unrelated to the current chat and edit commands
vovakulikov
approved these changes
Oct 1, 2024
abeatrix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSE https://linear.app/sourcegraph/issue/QA-81
Currently, some commands unrelated to the chat commands are not registered when unified prompts feature is enabled, which I believe is unintentional.
This PR add some documentations around some cody commands, and refactor the logic to make it clear what the new unified prompts commands are during the command registeration.
This PR also fixes the issue where the generate unit test command was unintentionally removed when the unified prompts feature is enabled.
Test plan
Manual Testing: Sign into S2 where the feature flag is enabled for all users.
Before this change, none of these commands were working because they were not registered when the unified prompts feature flag is enabled.
Changelog
Command: Fixed an issue where some commands (
Auto-EditandCody Explain Terminal Output) were not registered when the unified prompt feature flag is enabled.