Rename onebox telemetry metadata fields

[thenamankumar]

This PR renames a bunch of OneBox telemetry events metadata fields and make them camelcase.

This PR also removes the check isDotCom from the promptText private metadata field passed with the chat-question:executed event. None of the private metadata fields are sent to SG through the telemetery pipeline, so that data is still private, similar to the other present privateMetadata field. The only change is that the promptText will be recorded in the event_logs on that sourcegraph instance.

We need to remove the check so that we can selectively collect that field for the S2 instance, configured by a env var here: https://github.com/sourcegraph/cloud/pull/15143

Test plan

Make sure all the updated events are still recorded correctly.

Changelog

[akalia25]

Hey @thenamankumar I thought we were only interested in collecting query (or now promptText) for the event onebox.intentCorrection, curious why the scope has changed to now include cody.chat-question?

[akalia25]

We have been really strict on how we collect sensitive data like this, to ensure, it is never collected from customers. I do understand that privateMetadata is only collected for dotcom instances, but to relax this additional dotcom check for transcripts, I will need to confirm with the team we are okay with this.

[thenamankumar]

Yes @akalia25 , I have tagged the @sourcegraph/security-code-review to get approvals. We can do according to the suggestions.

To confirm again, @chenkc805 do we really need promptText for the chat-question:executed events on S2? Along with the detectedIntent, userSpecifiedIntent and intentScores?

context: https://linear.app/sourcegraph/issue/SRCH-1028/log-telemetry-of-the-output-of-the-intent-detection-model-with-each

[akalia25]

Hey @thenamankumar could we add an isS2() clause (similar to isDotCom()), that would allow for transcripts promptText/responseText to be stored for both dotcom instance and S2.

This would help avoid collecting this data on customer's local PG instance and keeping it extra secure.

[akalia25]

something like this: isDotCom(authStatus) || isS2(authStatus))

[thenamankumar]

I have removed this change for now from this PR.

[RXminuS]

@thenamankumar we should maybe sync on this tomorrow because I just removed the field all together after was told it was unused. #5558 Also there's a new way of invoking and testing these now, happy to walk you through it or have a look in lib/shared/src/telemetry-v2/events/at-mention.ts and vscode/e2e/telemetry/at-mention.test.ts

[github-actions]

‼️ Hey @sourcegraph/cody-security, please review this PR carefully as it introduces the usage of an unsafe_ function or abuses PromptString.

Removed then requested changes, unblocking to merge the rest renames.