-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify interface member names #4
Conversation
Signed-off-by: Juan Cruz Viotti <[email protected]>
498f61a
to
7b4cba5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (windows/msvc)
Benchmark suite | Current: 7b4cba5 | Previous: 8beccc8 | Ratio |
---|---|---|---|
Compiler_Draft6_AdaptiveCard |
11192177199.999947 ns/iter |
10679422299.999943 ns/iter |
1.05 |
Evaluator_Draft4_Meta_1_No_Callback |
2327.2299919310244 ns/iter |
2321.501873323783 ns/iter |
1.00 |
Evaluator_Draft4_Required_Properties |
2023.7334416665378 ns/iter |
2019.8302855626725 ns/iter |
1.00 |
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match |
543.5155999999779 ns/iter |
541.5579464285868 ns/iter |
1.00 |
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match |
409.82747723988456 ns/iter |
410.32971828879806 ns/iter |
1.00 |
Evaluator_Draft4_Items_Schema |
6679.793526785462 ns/iter |
6724.312500000655 ns/iter |
0.99 |
Evaluator_Draft4_Nested_Object |
155.71149553572639 ns/iter |
157.1494642857171 ns/iter |
0.99 |
Evaluator_Draft4_Properties_Triad_Optional |
5507.549107142447 ns/iter |
5425.583928572207 ns/iter |
1.02 |
Evaluator_Draft4_Properties_Triad_Closed |
4483.848750000163 ns/iter |
4484.02154282356 ns/iter |
1.00 |
Evaluator_Draft4_Properties_Triad_Required |
5567.54107142865 ns/iter |
5497.370000000501 ns/iter |
1.01 |
Evaluator_Draft4_Non_Recursive_Ref |
554.3582142857011 ns/iter |
553.2224107143285 ns/iter |
1.00 |
Evaluator_Draft4_Pattern_Properties_True |
8415.533482142935 ns/iter |
8335.014508928294 ns/iter |
1.01 |
Evaluator_Draft4_Ref_To_Single_Property |
411.8961021475116 ns/iter |
407.6669237648483 ns/iter |
1.01 |
Evaluator_Draft4_Additional_Properties_Type |
748.287611607168 ns/iter |
741.9450892857275 ns/iter |
1.01 |
Evaluator_Draft4_Nested_Oneof |
1087.8184374998766 ns/iter |
1094.178750000019 ns/iter |
0.99 |
Evaluator_Draft6_Property_Names |
1965.073272387008 ns/iter |
1987.5591602221757 ns/iter |
0.99 |
Evaluator_Draft7_If_Then_Else |
565.7022000000325 ns/iter |
563.2158035714342 ns/iter |
1.00 |
Evaluator_2020_12_Dynamic_Ref |
4760.269642857346 ns/iter |
4758.770666898485 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/llvm)
Benchmark suite | Current: 7b4cba5 | Previous: 8beccc8 | Ratio |
---|---|---|---|
Compiler_Draft6_AdaptiveCard |
4930818289.000001 ns/iter |
4898442454.000019 ns/iter |
1.01 |
Evaluator_Draft4_Meta_1_No_Callback |
962.1045903304284 ns/iter |
952.2393723051317 ns/iter |
1.01 |
Evaluator_Draft4_Required_Properties |
1577.1010648016004 ns/iter |
1565.3030805844558 ns/iter |
1.01 |
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match |
178.21682117974171 ns/iter |
176.64001764140465 ns/iter |
1.01 |
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match |
123.83103652175082 ns/iter |
121.93020279295445 ns/iter |
1.02 |
Evaluator_Draft4_Items_Schema |
3621.564433549351 ns/iter |
3569.914676727593 ns/iter |
1.01 |
Evaluator_Draft4_Nested_Object |
33.58753164116633 ns/iter |
32.34297684797143 ns/iter |
1.04 |
Evaluator_Draft4_Properties_Triad_Optional |
1705.0816759039833 ns/iter |
1698.7912407401452 ns/iter |
1.00 |
Evaluator_Draft4_Properties_Triad_Closed |
1420.51505482052 ns/iter |
1399.6681831629635 ns/iter |
1.01 |
Evaluator_Draft4_Properties_Triad_Required |
1802.1108307013758 ns/iter |
1762.2355628783482 ns/iter |
1.02 |
Evaluator_Draft4_Non_Recursive_Ref |
482.6214306045269 ns/iter |
480.63874225286884 ns/iter |
1.00 |
Evaluator_Draft4_Pattern_Properties_True |
2356.437449185462 ns/iter |
2327.1365454490747 ns/iter |
1.01 |
Evaluator_Draft4_Ref_To_Single_Property |
125.70936649270756 ns/iter |
127.004724404265 ns/iter |
0.99 |
Evaluator_Draft4_Additional_Properties_Type |
595.0736634525341 ns/iter |
597.7926483329634 ns/iter |
1.00 |
Evaluator_Draft4_Nested_Oneof |
478.66597761164644 ns/iter |
466.23393601410265 ns/iter |
1.03 |
Evaluator_Draft6_Property_Names |
1202.6711713765299 ns/iter |
1228.582144249061 ns/iter |
0.98 |
Evaluator_Draft7_If_Then_Else |
210.1306087828111 ns/iter |
208.24104504470017 ns/iter |
1.01 |
Evaluator_2020_12_Dynamic_Ref |
1832.2015947513908 ns/iter |
1906.4563601777636 ns/iter |
0.96 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/gcc)
Benchmark suite | Current: 7b4cba5 | Previous: 8beccc8 | Ratio |
---|---|---|---|
Evaluator_2020_12_Dynamic_Ref |
1960.2288633492328 ns/iter |
1969.6822999829765 ns/iter |
1.00 |
Evaluator_Draft7_If_Then_Else |
200.22014847793798 ns/iter |
199.19996280011225 ns/iter |
1.01 |
Evaluator_Draft6_Property_Names |
1277.6617178033462 ns/iter |
1278.7292591564644 ns/iter |
1.00 |
Evaluator_Draft4_Meta_1_No_Callback |
955.9561426779609 ns/iter |
950.8701842580502 ns/iter |
1.01 |
Evaluator_Draft4_Required_Properties |
1665.6052637830073 ns/iter |
1658.3929724380887 ns/iter |
1.00 |
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match |
182.56310542971787 ns/iter |
175.24907286570317 ns/iter |
1.04 |
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match |
128.60127272884068 ns/iter |
121.8358904349902 ns/iter |
1.06 |
Evaluator_Draft4_Items_Schema |
3502.021597605371 ns/iter |
3467.3380766525006 ns/iter |
1.01 |
Evaluator_Draft4_Nested_Object |
24.696564355796298 ns/iter |
24.08952947950012 ns/iter |
1.03 |
Evaluator_Draft4_Properties_Triad_Optional |
1712.3861583402936 ns/iter |
1740.0510842956055 ns/iter |
0.98 |
Evaluator_Draft4_Properties_Triad_Closed |
1438.9162867336918 ns/iter |
1484.5366729670293 ns/iter |
0.97 |
Evaluator_Draft4_Properties_Triad_Required |
1806.486984213766 ns/iter |
1844.7673523497824 ns/iter |
0.98 |
Evaluator_Draft4_Non_Recursive_Ref |
529.4560972990669 ns/iter |
541.2914487741119 ns/iter |
0.98 |
Evaluator_Draft4_Pattern_Properties_True |
2287.5453737734806 ns/iter |
2304.555728433697 ns/iter |
0.99 |
Evaluator_Draft4_Ref_To_Single_Property |
125.78190603912697 ns/iter |
126.36220405572136 ns/iter |
1.00 |
Evaluator_Draft4_Additional_Properties_Type |
566.4732468777876 ns/iter |
563.0720332174608 ns/iter |
1.01 |
Evaluator_Draft4_Nested_Oneof |
442.9481370870363 ns/iter |
443.0293400962545 ns/iter |
1.00 |
Compiler_Draft6_AdaptiveCard |
5032150071.00016 ns/iter |
4981907450.999984 ns/iter |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (macos/llvm)
Benchmark suite | Current: 7b4cba5 | Previous: 8beccc8 | Ratio |
---|---|---|---|
Compiler_Draft6_AdaptiveCard |
2817886209.000108 ns/iter |
2743149167.0000696 ns/iter |
1.03 |
Evaluator_Draft4_Meta_1_No_Callback |
738.2952685609214 ns/iter |
736.245972623849 ns/iter |
1.00 |
Evaluator_Draft4_Required_Properties |
933.95386064405 ns/iter |
933.3988811590391 ns/iter |
1.00 |
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match |
151.11326497182685 ns/iter |
150.9247368382772 ns/iter |
1.00 |
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match |
102.70074671520419 ns/iter |
102.28591357838374 ns/iter |
1.00 |
Evaluator_Draft4_Items_Schema |
2611.4486959082737 ns/iter |
2592.7297511892507 ns/iter |
1.01 |
Evaluator_Draft4_Nested_Object |
22.889239973175723 ns/iter |
23.38276848150369 ns/iter |
0.98 |
Evaluator_Draft4_Properties_Triad_Optional |
1264.7582092739378 ns/iter |
1257.7279598621353 ns/iter |
1.01 |
Evaluator_Draft4_Properties_Triad_Closed |
951.598565357391 ns/iter |
993.8030907717068 ns/iter |
0.96 |
Evaluator_Draft4_Properties_Triad_Required |
1289.9076785711936 ns/iter |
1359.771069525597 ns/iter |
0.95 |
Evaluator_Draft4_Non_Recursive_Ref |
211.72659180793107 ns/iter |
228.40501796093955 ns/iter |
0.93 |
Evaluator_Draft4_Pattern_Properties_True |
1331.6002321795463 ns/iter |
1421.4447791243256 ns/iter |
0.94 |
Evaluator_Draft4_Ref_To_Single_Property |
104.91650439408009 ns/iter |
113.86918634638319 ns/iter |
0.92 |
Evaluator_Draft4_Additional_Properties_Type |
404.11486096284665 ns/iter |
410.28651394297077 ns/iter |
0.98 |
Evaluator_Draft4_Nested_Oneof |
367.550771197076 ns/iter |
365.304529472791 ns/iter |
1.01 |
Evaluator_Draft6_Property_Names |
834.071741832067 ns/iter |
758.2504161294779 ns/iter |
1.10 |
Evaluator_Draft7_If_Then_Else |
169.67468452584507 ns/iter |
168.579710967086 ns/iter |
1.01 |
Evaluator_2020_12_Dynamic_Ref |
1390.0018563149426 ns/iter |
1391.5955858186023 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (macos/gcc)
Benchmark suite | Current: 7b4cba5 | Previous: 8beccc8 | Ratio |
---|---|---|---|
Compiler_Draft6_AdaptiveCard |
3733727931.9763184 ns/iter |
4099114179.611206 ns/iter |
0.91 |
Evaluator_Draft4_Meta_1_No_Callback |
767.1753134293834 ns/iter |
845.9410833840213 ns/iter |
0.91 |
Evaluator_Draft4_Required_Properties |
1018.9503562124905 ns/iter |
1090.748348955218 ns/iter |
0.93 |
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match |
172.0558111445222 ns/iter |
184.8970530108067 ns/iter |
0.93 |
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match |
119.15879001354314 ns/iter |
127.5083028128763 ns/iter |
0.93 |
Evaluator_Draft4_Items_Schema |
2505.861013029366 ns/iter |
2580.7269773599464 ns/iter |
0.97 |
Evaluator_Draft4_Nested_Object |
25.204136121163415 ns/iter |
26.892620247731386 ns/iter |
0.94 |
Evaluator_Draft4_Properties_Triad_Optional |
1534.5770080943648 ns/iter |
1617.2078397490818 ns/iter |
0.95 |
Evaluator_Draft4_Properties_Triad_Closed |
1394.6913202510527 ns/iter |
1409.2615644857312 ns/iter |
0.99 |
Evaluator_Draft4_Properties_Triad_Required |
1671.4179016775656 ns/iter |
1708.338580960717 ns/iter |
0.98 |
Evaluator_Draft4_Non_Recursive_Ref |
430.0365832521309 ns/iter |
498.4383106950866 ns/iter |
0.86 |
Evaluator_Draft4_Pattern_Properties_True |
1989.4531082431834 ns/iter |
2128.6919272396285 ns/iter |
0.93 |
Evaluator_Draft4_Ref_To_Single_Property |
119.4344829659897 ns/iter |
126.76187742878746 ns/iter |
0.94 |
Evaluator_Draft4_Additional_Properties_Type |
471.2992833340231 ns/iter |
509.1861890444606 ns/iter |
0.93 |
Evaluator_Draft4_Nested_Oneof |
370.55253404831194 ns/iter |
396.93048804068616 ns/iter |
0.93 |
Evaluator_Draft6_Property_Names |
923.6219301012114 ns/iter |
990.2111963994702 ns/iter |
0.93 |
Evaluator_Draft7_If_Then_Else |
188.351166030592 ns/iter |
200.0549998784205 ns/iter |
0.94 |
Evaluator_2020_12_Dynamic_Ref |
1662.486698351627 ns/iter |
1693.2104142576845 ns/iter |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: Juan Cruz Viotti [email protected]