completion: Support completion for optional chaining (&.) #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optional chaining allows to developers to call method only if the receiver is not nil. Therefore, CompletionProvider should consider the receiver is not nil if the optional chaining operator is given. This fix unwraps the Optional[T] from receiver_type on completion for the optional chaining. It will provide better completion for developers.
soutaro
reviewed
Jul 3, 2023
soutaro
reviewed
Jul 3, 2023
soutaro
requested changes
Jul 3, 2023
because types must be immutable.
|
Thank you for your wisdom. Updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optional chaining allows to developers to call method only if the receiver is not nil. Therefore, CompletionProvider should consider the receiver is not nil if the optional chaining operator is given.
This fix unwraps the Optional[T] from receiver_type on completion for the optional chaining. It will provide better completion for developers.