signature helps are not shown if the target code has comments #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SignatureHelpProvider fails to detect the cursor position correctly because it uses source code from AST node instead of original source code. Therefore it misdetects the cursor position if the source code contains comments. As a result, it does not show signature helps it the source code contains comments.
tk0miya
commented
Jul 2, 2023
soutaro
reviewed
Jul 3, 2023
soutaro
requested changes
Jul 3, 2023
|
Thank you for your valuable comment. I updated this PR :-) |
tk0miya
force-pushed
the
signature_help_is_not_shown_if_comment_found
branch
from
e6d6cc8
to
233e23c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SignatureHelpProvider fails to detect the cursor position correctly because it uses source code from AST node instead of original source code. Therefore it misdetects the cursor position if the source code contains comments. As a result, it does not show signature helps it the source code contains comments.