Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse the latest result to keep SignatureHelp opened while typing #835

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Reuse the latest result to keep SignatureHelp opened while typing #835

merged 1 commit into from
Jul 5, 2023

Conversation

tk0miya
Copy link
Contributor

@tk0miya tk0miya commented Jul 5, 2023 •
edited
Loading

refs: #834

Is sending the latest signature help response better if SyntaxError is raised?

It seems this approach working fine to me :-)

preview

soutaro
soutaro approved these changes Jul 5, 2023
View reviewed changes
Copy link
Owner

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro added this to the Steep 1.5 milestone Jul 5, 2023
@soutaro soutaro merged commit ee0a525 into soutaro:master Jul 5, 2023
20 checks passed
@soutaro soutaro added the Released The PR is already included in a published release label Jul 5, 2023
@tk0miya tk0miya deleted the reuse_latest_SignatureHelp_on_SyntaxError branch July 27, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
Released The PR is already included in a published release
Projects
None yet
Milestone
Steep 1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@tk0miya @soutaro