Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI and DAPS interaction issues #642

Merged
merged 13 commits into from
Nov 30, 2023
Merged

Fix CI and DAPS interaction issues #642

merged 13 commits into from
Nov 30, 2023

Conversation

richardtreier
Copy link
Collaborator

@richardtreier richardtreier commented Nov 29, 2023 •
edited
Loading

Checklist
Preview Give feedback

@richardtreier richardtreier force-pushed the 2023-11-28-fix-daps-interaction branch 2 times, most recently from 86ff667 to 6f57a3c Compare November 29, 2023 13:45
@richardtreier richardtreier force-pushed the 2023-11-28-fix-daps-interaction branch from aa2f155 to 778ce67 Compare November 30, 2023 09:17
@richardtreier richardtreier force-pushed the 2023-11-28-fix-daps-interaction branch from 65d735a to 986686a Compare November 30, 2023 14:19
@richardtreier richardtreier changed the title Fix DAPS interaction issues Fix CI and DAPS interaction issues Nov 30, 2023
@richardtreier richardtreier enabled auto-merge (squash) November 30, 2023 15:36
@richardtreier richardtreier mentioned this pull request Nov 30, 2023
Closed
jridderbusch
jridderbusch approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@jridderbusch jridderbusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@richardtreier richardtreier merged commit b064eb1 into main Nov 30, 2023
12 checks passed
@richardtreier richardtreier deleted the 2023-11-28-fix-daps-interaction branch November 30, 2023 16:06
@richardtreier richardtreier mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridderbusch jridderbusch jridderbusch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contract Negotiation Fails Tests fail in CI but not locally
2 participants
@richardtreier @jridderbusch