Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCPListener fix for #25 #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

TCPListener fix for #25 #33

wants to merge 1 commit into from

Conversation

soypat
Copy link
Owner

@soypat soypat commented Oct 24, 2024

Attempting to fix bug in TCPListener, which leaks a connection on RST receive.

See #25

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 56.25000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 46.03%. Comparing base (1201bab) to head (66c9a7d).

Files with missing lines Patch % Lines
stacks/portstack.go 0.00% 9 Missing and 1 partial ⚠️
stacks/tcplistener.go 80.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   45.99%   46.03%   +0.03%     
==========================================
  Files          29       29              
  Lines        4937     4946       +9     
==========================================
+ Hits         2271     2277       +6     
- Misses       2406     2410       +4     
+ Partials      260      259       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soypat
Copy link
Owner Author

soypat commented Oct 24, 2024

Not having much time to work on this right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant