Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add odometry and lidar to mars_rover model for Nav2 #10
Add odometry and lidar to mars_rover model for Nav2 #10
Changes from all commits
5e6b4f4
504df16
6505526
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this works as intended in the new Gazebo, I'm planning to try out this along with supporting PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm not sure it does either because I saw a warning when I ran, but I also saw that the camera has a material specified
simulation/models/curiosity_path/urdf/sensor_mast.xacro
Line 262 in 1307f4f
and I do see the lidar show up as black. If this is wrong let me know I can remove or change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the new Gazebo can't parse 'Gazebo/' materials, its recently added to Harmonic. For rendering green, you might need to change it to:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@quarkytale - what if I remove the material tag entirely? If it isn't being parsed, I would guess it's ignored and it will make no technical difference if I remove it, except to clean up dead code, which is good.