-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a Method to Support Dynamic Element Sizes in Sequence
#44
feat: Add a Method to Support Dynamic Element Sizes in Sequence
#44
Conversation
Sorry for the delay on this. @jacobtrombetta would be good to get your input here. |
We should update the
This will allow us to minimize duplicate code. |
Signed-off-by: Tarek <[email protected]>
Signed-off-by: Tarek <[email protected]>
583543f
to
1447f50
Compare
Thanks for the review. I’ve updated the PR to address your comments and rebased it on top of main. Let me know if there’s anything else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 3.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Rationale for this change
So far, all the methods to create a
Sequence
seem to be on statically sized types.For more context, check out spaceandtimelabs/sxt-proof-of-sql#240 (comment)
What changes are included in this PR?
Implement
from_raw_parts_with_size()
for handling variable-sized elements.Are these changes tested?
Yes. Added a test
we_can_convert_a_slice_of_fixed_size_binary_to_a_sequence_with_correct_data()
to verify the changes