You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
NOTE: #230 should be completed before this ticket can be done. Additionally, be aware that some of the code changes for this issue are likely to conflict with the code changes in the following issue: #234
Currently, we have reference to 3 types that we want removed from proof-of-sql/src/base:
Curve25519Scalar
RistrettoPoint
InnerProductProof
Any references to these types should be moved to the proof_primitive directory in its own directory named "inner_product". Ultimately, we are trying to remove all cyclic dependencies caused by these types.
Changes Required
Each of these should be a separate PR.
Move Curve25519Scalar and its unit tests to new directory proof_primitive/inner_product.
Move RistrettoPoint and its unit tests to inner_product.
Move InnerProductProof and its unit tests to inner_product.
If there is any reference to any of these types remaining (most likely within a test), either move those to inner_product or replace with one of TestScalar, NaiveCommitment, or TestEvaluationProof.
The text was updated successfully, but these errors were encountered:
Start working: (Optional) Comment /attempt #232 with your implementation plan. Note: we will only assign an issue if you include an implementation plan with a time estimate. Additionally, to be assigned an issue, you must have previously contributed to the project. You can still work on an issue and submit a PR without being assigned.
Submit work: Create a pull request including /claim #232 in the PR body to claim the bounty
Background and Motivation
NOTE: #230 should be completed before this ticket can be done. Additionally, be aware that some of the code changes for this issue are likely to conflict with the code changes in the following issue:
#234
Currently, we have reference to 3 types that we want removed from proof-of-sql/src/base:
Any references to these types should be moved to the proof_primitive directory in its own directory named "inner_product". Ultimately, we are trying to remove all cyclic dependencies caused by these types.
Changes Required
Each of these should be a separate PR.
The text was updated successfully, but these errors were encountered: