Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up scalar module #234

Closed
2 tasks done
stuarttimwhite opened this issue Oct 7, 2024 · 6 comments
Closed
2 tasks done

Tidy up scalar module #234

stuarttimwhite opened this issue Oct 7, 2024 · 6 comments
Labels
💎 Bounty good first issue Good for newcomers refactor Code cleanup or reorganization 💰 Rewarded

Comments

@stuarttimwhite
Copy link
Contributor

stuarttimwhite commented Oct 7, 2024

Background and Motivation

MontScalar and Scalar logic is currently disorganized. We should consolidate this logic.

NOTE: The following issues are likely to modify the same files, so be aware of potential merge conflicts with other PRs:

  1. Move InnerProductTypes out of base to proof_primitive #232
  2. Make opaque Scalar conversions explicit rather than using From/Into trait. #228

Changes Required

  • Combine any logic held within the four files "mont_scalar", "mont_scalar_from", "mont_scalar_test", "mont_scalar_from_test" into two files "mont_scalar" and "mont_scalar_test".
  • Move the Scalar trait to its own "scalar" file within base/scalar.
@JayWhite2357 JayWhite2357 changed the title Downsize MontScalar logic into one file Tidy up scalar module Oct 7, 2024
@JayWhite2357 JayWhite2357 added the enhancement New feature or request label Oct 8, 2024
@JayWhite2357 JayWhite2357 added refactor Code cleanup or reorganization good first issue Good for newcomers and removed enhancement New feature or request labels Oct 9, 2024
@JayWhite2357
Copy link
Contributor

/bounty $10

Copy link

algora-pbc bot commented Oct 9, 2024

💎 $10 bounty • Space and Time

Steps to solve:

  1. Start working: (Optional) Comment /attempt #234 with your implementation plan. Note: we will only assign an issue if you include an implementation plan with a time estimate. Additionally, to be assigned an issue, you must have previously contributed to the project. You can still work on an issue and submit a PR without being assigned.
  2. Submit work: Create a pull request including /claim #234 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to spaceandtimelabs/sxt-proof-of-sql!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @winrhcp Oct 10, 2024, 10:53:36 AM #251

@winrhcp
Copy link
Contributor

winrhcp commented Oct 10, 2024

/attempt #234

Copy link

algora-pbc bot commented Oct 10, 2024

💡 @winrhcp submitted a pull request that claims the bounty. You can visit your bounty board to reward.

@JayWhite2357
Copy link
Contributor

Completed by #255

Copy link

algora-pbc bot commented Oct 19, 2024

🎉🎈 @winrhcp has been awarded $10! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 Bounty good first issue Good for newcomers refactor Code cleanup or reorganization 💰 Rewarded
Projects
None yet
Development

No branches or pull requests

3 participants