refactor!: expose random public parameter generation #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dustin-Ray
changed the title
Dustin-Ray
changed the title
Dustin-Ray
force-pushed
the
refactor/random-g1-vecs-for-public-parameters
branch
from
261cc7d
to
b9d5aba
Compare
Dustin-Ray
commented
Oct 2, 2024
crates/proof-of-sql/src/proof_primitive/dory/public_parameters.rs
Outdated
Show resolved
Hide resolved
Dustin-Ray
commented
Oct 2, 2024
crates/proof-of-sql/src/proof_primitive/dory/public_parameters.rs
Outdated
Show resolved
Hide resolved
Dustin-Ray
force-pushed
the
refactor/random-g1-vecs-for-public-parameters
branch
2 times, most recently
from
ea42e51
to
78b4c33
Compare
Dustin-Ray
commented
Oct 3, 2024
Dustin-Ray
force-pushed
the
refactor/random-g1-vecs-for-public-parameters
branch
from
fc883da
to
86791dc
Compare
Dustin-Ray
changed the title
Dustin-Ray
force-pushed
the
refactor/random-g1-vecs-for-public-parameters
branch
2 times, most recently
from
0ffe3df
to
f4264d7
Compare
JayWhite2357
reviewed
Oct 3, 2024
crates/proof-of-sql/src/proof_primitive/dory/public_parameters.rs
Outdated
Show resolved
Hide resolved
Dustin-Ray
changed the title
… sxt-db fmt revert function name change rand impl for public parameters refactor fix! rename rand functions test feature flag
Dustin-Ray
force-pushed
the
refactor/random-g1-vecs-for-public-parameters
branch
from
f7c5f97
to
644022e
Compare
|
🎉 This PR is included in version 0.26.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
If PublicParameters are generated within sxtDB and not an argument passed in via protobuf, then we need a way to randomly generate the setup within external crates such as sxtdb. This PR exposes a trait bounded method requiring a CSRNG which generates the public parameters securely.
What changes are included in this PR?
test_randAre these changes tested?
existing tests pass