refactor: tidy up decimal module
#294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cimalExt::try_into_scalar_with_precision_and_scale`
…DecimalExt` trait and make it private
… into `DecimalError`
JayWhite2357
force-pushed
the
refactor/tidy-decimal-module
branch
from
6af560f
to
f63ae2e
Compare
Dustin-Ray
reviewed
Oct 22, 2024
| pub trait BigDecimalExt { | ||
| fn precision(&self) -> u64; | ||
| fn scale(&self) -> i64; | ||
| fn try_into_bigint_with_precision_and_scale( | ||
| /// Fallibly attempts to convert an `IntermediateDecimal` into the |
There was a problem hiding this comment.
I dont think we have the IntermediateDecimal type anymore?
Dustin-Ray
reviewed
Oct 22, 2024
| #[derive(Eq, PartialEq, Debug, Clone, Hash, Serialize, Copy)] | ||
| /// limit-enforced precision | ||
| pub struct Precision(u8); | ||
| pub(super) const MAX_SUPPORTED_PRECISION: u8 = 75; |
There was a problem hiding this comment.
this could use a doc comment
Dustin-Ray
reviewed
Oct 22, 2024
| }, | ||
| } | ||
| })?; | ||
| let _max_precision = Precision::new(max_precision_value)?; |
There was a problem hiding this comment.
why is this unused? would it be better to have a check function that didnt require an unused variable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
After #283, the
math::decimalmodule is a bit untidy, especially around error types and tests.What changes are included in this PR?
This reorganizes the module, tidies things up, and adds some more thorough unit tests.
Please look at the individual commits since there is a lot of code moved, and the individual commits are smaller than the aggregate.
Are these changes tested?
Yes