refactor!: replace output of result_evaluate and final_round_evaluate of ProofPlan with Table
#371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
force-pushed
the
feat/output-table
branch
from
2550185
to
531ba7c
Compare
iajoiner
force-pushed
the
feat/output-table
branch
from
14d2dec
to
3b06fec
Compare
iajoiner
force-pushed
the
feat/output-table
branch
2 times, most recently
from
0d76046
to
6946dfc
Compare
…` return `Table`
…o simplify the code
iajoiner
force-pushed
the
feat/output-table
branch
6 times, most recently
from
c1c6d41
to
e0a9b32
Compare
iajoiner
force-pushed
the
feat/output-table
branch
5 times, most recently
from
324d312
to
72e3cb9
Compare
iajoiner
force-pushed
the
feat/output-table
branch
from
72e3cb9
to
3bd1402
Compare
…ble>` for `ProvableQueryResult`
JayWhite2357
requested changes
Nov 14, 2024
JayWhite2357
approved these changes
Nov 14, 2024
|
🎉 This PR is included in version 0.46.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.Rationale for this change
To make
ProofPlans composable it is more natural for us to returnTables inresult_evaluateandfinal_round_evaluateinProofPlan.What changes are included in this PR?
result_evaluateandfinal_round_evaluateofProofPlanwithTableTable::columns,ProvableQueryResult::new_from_tableto simplify the codeAre these changes tested?
Yes.