Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang: updated Turkish Translation #658

Merged
merged 2 commits into from
Mar 9, 2025

Conversation

mikropsoft
Copy link
Contributor

I re-translated the file by syncing it with the English string file, so it might look complicated. While there are 2 spaces on the left side of the English strings in the translations, the existing Turkish file has 4 spaces. I left it as it should be. Since I’m not using Weblate, I’m opening a PR; if you don’t want to merge it, I’d appreciate it if you could at least upload it to Weblate.

I re-translated the file by syncing it with the English string file, so it might look complicated. While there are 2 spaces on the left side of the English strings in the translations, the existing Turkish file has 4 spaces. I left it as it should be. Since I’m not using Weblate, I’m opening a PR; if you don’t want to merge it, I’d appreciate it if you could at least upload it to Weblate.
@spacecowboy
Copy link
Owner

I don't mind PRs for translations but you've broken the build. The app doesn't compile with your changes.

I believe the reason is there are now apostrophes in the strings. For example:

<string name="add_feed_search_hint">Besleme URL'si</string>

These must be escaped. Here is an example of that from the french strings:

<string name="failed_to_fetch_full_article_missing_body">Il n\'y a rien à récupérer</string>

@mikropsoft
Copy link
Contributor Author

Hmm, I thought I had done these, but I forgot. I was aware of this requirement. I'll change it tomorrow.

By the way, the edit permissions on the PR should be open, so you can fix it if you want.

@mikropsoft
Copy link
Contributor Author

@spacecowboy done.

@spacecowboy spacecowboy changed the title Update Turkish Translation lang: updated Turkish Translation Mar 9, 2025
@spacecowboy spacecowboy merged commit cab4da1 into spacecowboy:master Mar 9, 2025
8 of 11 checks passed
@spacecowboy
Copy link
Owner

@spacecowboy done.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants