feat: create Azure flavor #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavlasko
force-pushed
the
create-azure-image
branch
2 times, most recently
from
1e39547
to
12b169a
Compare
Create a flavor of the image that contains the azcli. This will be useful for stacks that want to use ansible and need Azure credentials - i.e. connecting to AKS with `kubelogin` requires the Azure CLI.
Azure CLI requires gcc and a few others, so we must install them. We need to elevate to root to do the `apk add`, but we then de-elevate back when we're done.
When using pip install, it really wants us to use virtual python environments, and will fail if we try to pip install the Azure CLI globally. Since we have a very constrained use case for the runner, we are OK with installing globally, as there's nothing else using the Azure CLI to clobber.
gustavlasko
force-pushed
the
create-azure-image
branch
from
09ae7c0
to
7efa226
Compare
eliecharra
reviewed
Aug 6, 2024
There was a problem hiding this comment.
Thanks for your contribution.
We are currently reworking the way we build images on this repo, so we can't really merge this PR 🙇🏻
That being said, we'll introduce an Azure flavor with the Azure CLI built-in
8 tasks
|
Closing in favor of #21 @gustavlasko Can you try it with one of the following images, and let us know if it works for you? public.ecr.aws/spacelift/runner-ansible:10-azure
# You can also use a tag pointing to a minor version if you want better control
public.ecr.aws/spacelift/runner-ansible:10.1-azureAlso, bear in mind that this is still a work in progress, so please do not use this image for production yet 🙏🏻 |
|
Thanks, we're rolling now with the Azure/Ansible image that you released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Create a flavor of the image that contains the azcli. This will be useful for stacks that want to use ansible and need Azure credentials - i.e. connecting to AKS with
kubeloginrequires the Azure CLI.Type of change
Checklists
Development
Code review