Drop cursor from flags

spacelift-io · Aug 29, 2024 · 90e78ad · 90e78ad
1 parent 0003539
commit 90e78ad
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 24 deletions.
diff --git a/internal/cmd/stack/flags.go b/internal/cmd/stack/flags.go
@@ -163,11 +163,6 @@ var flagLimit = &cli.UintFlag{
 	Usage: "[Optional] Limit the number of items to return",
 }
 
-var flagCursor = &cli.StringFlag{
-	Name:  "cursor",
-	Usage: "[Optional] Cursor indicates the point after which to return results, allowing for fetching the next set of results in a paginated query.",
-}
-
 var flagSearch = &cli.StringFlag{
 	Name:  "search",
 	Usage: "[Optional] Search performs a full-text search on fields: \"name\", \"slug\" and \"label\".",

diff --git a/internal/cmd/stack/list.go b/internal/cmd/stack/list.go
@@ -101,7 +101,6 @@ func searchAllStacks(ctx context.Context, input structs.SearchInput) ([]stack, e
 
 	pageInput := structs.SearchInput{
 		First:          graphql.NewInt(50),
-		After:          input.After,
 		FullTextSearch: input.FullTextSearch,
 	}
 	for {

diff --git a/internal/cmd/stack/paging.go b/internal/cmd/stack/paging.go
@@ -11,7 +11,6 @@ import (
 type paging struct {
 	Limit  *uint
 	Search *string
-	Cursor *string
 }
 
 func newPaging(cliCtx *cli.Context) (paging, error) {
@@ -33,41 +32,26 @@ func newPaging(cliCtx *cli.Context) (paging, error) {
 		search = internal.ToPtr(cliCtx.String(flagSearch.Name))
 	}
 
-	var cursor *string
-	if cliCtx.IsSet(flagCursor.Name) {
-		if cliCtx.String(flagCursor.Name) == "" {
-			return paging{}, fmt.Errorf("cursor must be non-empty")
-		}
-
-		cursor = internal.ToPtr(cliCtx.String(flagCursor.Name))
-	}
-
 	return paging{
 		Limit:  limit,
 		Search: search,
-		Cursor: cursor,
 	}, nil
 }
 
 func (p paging) toSearchInput() structs.SearchInput {
-	var after, fullTextSearch *graphql.String
+	var fullTextSearch *graphql.String
 
 	if p.Search != nil {
 		fullTextSearch = graphql.NewString(graphql.String(*p.Search))
 	}
 
-	if p.Cursor != nil {
-		after = graphql.NewString(graphql.String(*p.Cursor))
-	}
-
 	var first *graphql.Int
 	if p.Limit != nil {
 		first = graphql.NewInt(graphql.Int(*p.Limit))
 	}
 
 	return structs.SearchInput{
 		First:          first,
-		After:          after,
 		FullTextSearch: fullTextSearch,
 	}
 }
diff --git a/internal/cmd/stack/stack.go b/internal/cmd/stack/stack.go
@@ -141,7 +141,6 @@ func Command() *cli.Command {
 					cmd.FlagOutputFormat,
 					cmd.FlagNoColor,
 					flagLimit,
-					flagCursor,
 					flagSearch,
 				},
 				Action:    listStacks(),