Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new commands for prioritizing/deprioritizing a run and flag to prioritize local-preview #243

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

0michalsokolowski0
Copy link
Contributor

@0michalsokolowski0 0michalsokolowski0 commented Aug 26, 2024

Closes #241.

In this PR, I am:

  • Adding a new command prioritize to the stack allows you to prioritize a run to match the functionality in the UI.
    Example:
spacectl stack prioritize --id=<stack-id> --run=<run-id>

image

  • Adding a new command deprioritize to the stack allows you to deprioritize a run to match the functionality in the UI.
    Example:
spacectl stack deprioritize --id=<stack-id> --run=<run-id>
  • Adding a flag prioritize-run to local-preview, which allows to prioritize the local-preview run after it's triggered automatically
    Example:
spacectl stack local-preview --id=<stack-id> --prioritize-run

image

Copy link
Contributor

@mbialon mbialon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@tomasmik tomasmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just a few little nits

internal/cmd/stack/local_preview.go Outdated Show resolved Hide resolved
internal/cmd/stack/run_prioritize.go Outdated Show resolved Hide resolved
internal/cmd/stack/run_prioritize.go Show resolved Hide resolved
@0michalsokolowski0 0michalsokolowski0 changed the title feat: Add new command for prioritizing a run and flag to prioritize local-preview feat: Add new command for prioritizing/deprioritizing a run and flag to prioritize local-preview Aug 26, 2024
@0michalsokolowski0 0michalsokolowski0 changed the title feat: Add new command for prioritizing/deprioritizing a run and flag to prioritize local-preview feat: Add new commands for prioritizing/deprioritizing a run and flag to prioritize local-preview Aug 26, 2024
Copy link
Contributor

@tomasmik tomasmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work

@0michalsokolowski0 0michalsokolowski0 merged commit 146bf07 into main Aug 27, 2024
9 checks passed
@0michalsokolowski0 0michalsokolowski0 deleted the add-prioritize-command branch August 27, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to prioritise runs
3 participants