Allow to delete a module version #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasmik
requested review from
mbialon,
Yantrio,
silviutanasa and
0michalsokolowski0
tomasmik
commented
Sep 13, 2024
| @@ -8,6 +8,12 @@ var flagModuleID = &cli.StringFlag{ | |||
| Required: true, | |||
| } | |||
|
|
|||
| var flagVersionID = &cli.StringFlag{ | |||
| Name: "versionid", | |||
There was a problem hiding this comment.
not a fan of this, but life is life. unless someone has a better idea?
There was a problem hiding this comment.
Maybe we could provide the version itself, not the ID?
There was a problem hiding this comment.
that would require changes in the backend, so i'd rather not do that :/
0michalsokolowski0
approved these changes
Sep 13, 2024
mbialon
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➜ spc module delete-version --id gitlbam --versionid 01J537F77FRHBXVSEPXWNGFBX4 Module version "1.7.5" has been deletedWe already allow you to create versions using spacectl, so let's allow you to delete them as well.
Closes: #254